Convert commands over to use pflag library for POSIX style opts #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu-gott
approved these changes
Jul 21, 2017
There was a problem hiding this comment.
So it occurred to me to check the hack, cluster, and manifests directories to see if we were using this behavior anywhere. We're not calling any scripts using single-flag notation, but at least one script is using this same approach: cluster/vm-isolation-check.sh
rmohr
approved these changes
Jul 21, 2017
|
needs a rebase. Otherwise fine. |
The standard Go flag library treats long & short options as identical (eg --foo & -foo are the same). This prevents the creation of short aliases for flags. The replacement pflag library supports full POSIX opts syntax where long and short options are distinct. The virtctl command already uses this library. Convert the remaining commands over to use it too, so we can later add short options for common args. Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
|
Rebased |
kubevirt-bot
pushed a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Nov 6, 2020
* add e2e functional test steps * addressing comments
kubevirt-bot
pushed a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Dec 7, 2021
At multi node cluster non master nodes were missing the node-role label at all , also mono node cluster has only master node-role, all this prevent some testing that depends on those labels. Signed-off-by: Quique Llorente <ellorent@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard Go flag library treats long & short options as
identical (eg --foo & -foo are the same). This prevents the
creation of short aliases for flags. The replacement pflag
library supports full POSIX opts syntax where long and
short options are distinct. The virtctl command already
uses this library. Convert the remaining commands over to
use it too, so we can later add short options for common
args.
Signed-off-by: Daniel P. Berrange berrange@redhat.com