Move "test" directory to "pkg/testutils" #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There should at least also be references in the functional test folder ... Could you have a closer look again? |
Having top level directories called "test" and "tests" is rather confusing. For even more confusion the go files in the "test" directory declare they are in a go package called "rest". Rename the "test" directory to "pkg/testutils" and the go package to "testutils". Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
|
There's no sign of anything in the tests/ directory using this module.. |
|
Ah ok, travis just detected formatting issues ... |
rmohr
approved these changes
Jul 20, 2017
mzzgaopeng
pushed a commit
to mzzgaopeng/kubevirt
that referenced
this pull request
Mar 8, 2021
ipam/host-local: add ResolvConf argument for DNS configuration
kubevirt-bot
pushed a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Dec 7, 2021
Signed-off-by: Roman Mohr <rmohr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having top level directories called "test" and "tests" is
rather confusing. For even more confusion the go files in
the "test" directory declare they are in a go package called
"rest". Rename the "test" directory to "pkg/testutils" and
the go package to "testutils".
Signed-off-by: Daniel P. Berrange berrange@redhat.com