Remove unused third_party/swagger-ui directory #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The swagger-ui content is needed by the virt-api service, but the virt-api Dockerfile never uses the content that is in the GIT tree third_party/swagger-ui directory. Instead it downloads a specific version directly from the upstream repo and unpacks that in the container image. Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
stu-gott
approved these changes
Jul 21, 2017
mzzgaopeng
pushed a commit
to mzzgaopeng/kubevirt
that referenced
this pull request
Mar 8, 2021
libcni conf: support .json file extension
kubevirt-bot
pushed a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Dec 7, 2021
There is no user `oscollabus` but there is `oshoval` that is part of the kubevirt org with `oscollabus` as their name Signed-off-by: Andrew Beekhof <andrew@beekhof.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The swagger-ui content is needed by the virt-api service,
but the virt-api Dockerfile never uses the content that
is in the GIT tree third_party/swagger-ui directory. Instead
it downloads a specific version directly from the upstream
repo and unpacks that in the container image.
Signed-off-by: Daniel P. Berrange berrange@redhat.com