Move manifests from TPRs to CRDs #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 I actually thought if it makes sense to stick to CRDs for even a bit longer, until there is a nice fix for kubernetes/kubernetes#46351. My concern is that - with the UAS stuff @stu-gott is working on - we'll need to introduce etcd or alike which I wanted to prevent, as it has many implications. At best Kube will start to offer a method to store simple CRD like objects of UAS in it's API server which we can then leverage from our UAS. If we still want to move to UAS but not use an etcd instance, then I'd even consider to use a plain volume and store json blobs there (instead of having a dedicated etcd or alike instance). |
fabiand
approved these changes
Aug 8, 2017
Signed-off-by: Roman Mohr <rmohr@redhat.com>
kubevirt-bot
pushed a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Nov 6, 2020
mzzgaopeng
pushed a commit
to mzzgaopeng/kubevirt
that referenced
this pull request
Mar 8, 2021
invoke: Enable plugin file names with extensions
mzzgaopeng
pushed a commit
to mzzgaopeng/kubevirt
that referenced
this pull request
Mar 8, 2021
invoke: Enable plugin file names with extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aglitke that should fix your problem with the latest kubernetes code from github master. TPRs don't exist there anymore.
Since the switch from TPRs to CRDs is very easy, I would suggest that we do it, although we get our own apiserver within the next one or two weeks. @fabiand @stu-gott thoughts?
Signed-off-by: Roman Mohr rmohr@redhat.com