Restore controller in memory corrution #4297
Conversation
kubevirt-bot
added
release-note-none
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
mhenriks
force-pushed
the
restore-corruption
branch
from
efc2787
to
c1cca8e
Compare
| @@ -343,8 +349,13 @@ func (t *vmRestoreTarget) Reconcile() (bool, error) { | |||
| var deletedDataVolumes []string | |||
| updatedStatus := false | |||
|
|
|||
| copy(newTemplates, snapshotVM.Spec.DataVolumeTemplates) | |||
| copy(newVolumes, snapshotVM.Spec.Template.Spec.Volumes) | |||
| for i, t := range snapshotVM.Spec.DataVolumeTemplates { | |||
There was a problem hiding this comment.
this was actually the problematic block. snapshotVM.Spec.Template.Spec.Volumes was getting overwritten
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/cherry-pick release-0.34 |
|
@mhenriks: new pull request created: #4308 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
make sure to deep copy resources in informer caches
was mistakenly overwriting VirtualMachineSnapshotContent
kept us from restoring from the same snapshot twice
Signed-off-by: Michael Henriksen mhenriks@redhat.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: