New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge kubevirt/libvirt into kubevirt/kubevirt #4703
Conversation
Skipping CI for Draft Pull Request. |
/cc @crobinso FYI |
/test pull-kubevirt-e2e-k8s-1.18 |
/test all |
1dfa44c
to
dfdf194
Compare
Ready for reviews. |
Signed-off-by: Roman Mohr <rmohr@redhat.com>
Signed-off-by: Roman Mohr <rmohr@redhat.com>
Signed-off-by: Roman Mohr <rmohr@redhat.com>
Prefer common-logos over fedlora-logs package. Signed-off-by: Roman Mohr <rmohr@redhat.com>
Signed-off-by: Roman Mohr <rmohr@redhat.com>
Signed-off-by: Roman Mohr <rmohr@redhat.com>
Signed-off-by: Roman Mohr <rmohr@redhat.com>
Signed-off-by: Roman Mohr <rmohr@redhat.com>
This target can be used to verify RPMs in the WORKSPACE in CI and on local RPM updates. Signed-off-by: Roman Mohr <rmohr@redhat.com>
Signed-off-by: Roman Mohr <rmohr@redhat.com>
Signed-off-by: Roman Mohr <rmohr@redhat.com>
A no longer needed leftover. Signed-off-by: Roman Mohr <rmohr@redhat.com>
Our `ldd` run target should get an up-to-date libvirt-devel tar automatically. For an unknown reason it can provide an outdated version if not explicitly built before. Working around this for now. Signed-off-by: Roman Mohr <rmohr@redhat.com>
The virt-operator image is a bad candidate and now tests broke, since it is now a distroless container without the necessary dependencies. Signed-off-by: Roman Mohr <rmohr@redhat.com>
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rmohr: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
These images are not needed after kubevirt#4703 Signed-off-by: Federico Gimenez <fgimenez@redhat.com>
These images are not needed after kubevirt#4703 Signed-off-by: Federico Gimenez <fgimenez@redhat.com>
What this PR does / why we need it:
Centralize our dependency management by using https://github.com/rmohr/bazeldnf to resolve our RPMs on a bazel level.
This allows us to have only
bazel
and ` C-toolchain as an external dependency. All shared libraries can now consumed fully through bazel.Benefits are:
Run
to update RPM dependencies to the latest state.
Modify
repo.yaml
to use different fedora or copr versions. Initially it looks like this:Finally a
make verify-rpm-deps
target was added to ensure that all referenced RPMs are signed by known GPG keys. This will be integrated in CI, to allow engineers to locally update and modify RPM dependencies.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
More background can be found at https://github.com/rmohr/bazeldnf.
In short,
bazeldnf
does:rpmtree
target, which is not much more than just a bundle of RPMs converted into single tar archives. It can be used for instance as a container-layer, or as a source for required headers or libraries.tar2files
target which can make a selected subset of headers and shared libraries available forcc_library
rules by taking tar files (like emited fromrpmtree
targets) as input. Finallycc_library
targets can then be passed togo
code and used viacgo
.bazeldnf
has a sub-command calledldd
which can resolve transitive dependencies of shared libraries and write them astar2files
targets. This ensures linking only required shared libraries.Release note: