[release-0.36] Add error message on virtctl image-upload to WaitForFirstConsumer DataVolume #4824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aVolume When the DV is in phase WaitForFirstConsumer the PVC cannot be bound until first consumer pod shows up, so the upload is not possible. Previously the virtclt timed out, and now it shows an error informing what happened. The check only works for upload to DataVolume. Implementing this check for upload to PVC would mean re-implementing CDI logic that updates DataVolume state. It is assumed that users wanting to utilize all CDI functionality use DataVolumes, and users that use PVC have a good reason not to use DV. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>
Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>
kubevirt-bot
added
release-note
rmohr
changed the title
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rmohr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A manual backport of #4779 to release-0.36
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
https://bugzilla.redhat.com/show_bug.cgi?id=1913320
Special notes for your reviewer:
Release note: