Fixes migration controller null pointer dereference #5694
Conversation
Signed-off-by: David Vossel <davidvossel@gmail.com>
kubevirt-bot
added
release-note
|
/lgtm |
There was a problem hiding this comment.
@davidvossel Great catch!
There is some issue with the migration unit tests(I've reproduced the fails locally using this PR as a rebase). Trying to find out the root cause. Can you please take a look?
@davidvossel OK I think that we probably should not expect the VMI to be patched while |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stu-gott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/hold looking into unit tests |
kubevirt-bot
added
the
do-not-merge/hold
Signed-off-by: David Vossel <davidvossel@gmail.com>
davidvossel
force-pushed
the
migration-segfault
branch
from
2d0896c
to
5167f64
Compare
kubevirt-bot
added
size/M
and removed
lgtm
|
/hold cancel Thanks @enp0s3, the unit test were indeed failing. Odd that CI didn't catch this though. I've fixed the tests and improved how we validate the patch contents in the tests as well. |
kubevirt-bot
removed
the
do-not-merge/hold
|
/cherry-pick release-0.41 |
|
@davidvossel: once the present PR merges, I will cherry-pick it on top of release-0.41 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-0.36 |
|
@davidvossel: once the present PR merges, I will cherry-pick it on top of release-0.36 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-0.34 |
|
@davidvossel: once the present PR merges, I will cherry-pick it on top of release-0.34 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@davidvossel: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@davidvossel: new pull request created: #5707 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@davidvossel: new pull request created: #5708 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@davidvossel: new pull request created: #5709 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This PR seems to cause goveralls to fail |
If a migration object transistions to "Failed" before being handed off to virt-controller, it's possible that we'll attempt to access the vmi.Status.MigrationState when it's an uninitialized null pointer. This can happen for example if the target pod fails during execution before the handoff, or if the target pod is somehow deleted before the handoff.
The result is that virt-controller can get into a situation where it crash loops until the effected migration object is removed from the cluster.