Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.41]Increase memory for validation of container disk #5866

Merged
merged 1 commit into from Jun 23, 2021
Merged

[release-0.41]Increase memory for validation of container disk #5866

merged 1 commit into from Jun 23, 2021

Conversation

xpivarc
Copy link
Member

@xpivarc xpivarc commented Jun 18, 2021

What this PR does / why we need it:
This fix is for newer versions of golang(1.14+) which seems to allocate more memory for exec.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Fix: Kubevirt build with golang 1.14+ will not fail on validation of container disk with memory allocation error

@xpivarc
Increase memory for validation of container disk
c5c2cbe 
This fix is for newer versions of golang(1.14+)
which seems to allocate more memory for exec.

Signed-off-by: L. Pivarc <lpivarc@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 18, 2021
@dhiller
Copy link
Contributor

dhiller commented Jun 18, 2021

/retest

dhiller
dhiller approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@ashleyschuett
Copy link
Contributor

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashleyschuett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2021
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@dhiller
Copy link
Contributor

dhiller commented Jun 22, 2021

/retest

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@dhiller
Copy link
Contributor

dhiller commented Jun 23, 2021

/retest

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@dhiller
Copy link
Contributor

dhiller commented Jun 23, 2021

/hold

@xpivarc i see that the test test_id:5004 failed on every run for the job pull-kubevirt-e2e-k8s-1.18 on the latest commit, could you take a look, please?

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2021
@xpivarc
Copy link
Member Author

xpivarc commented Jun 23, 2021

/hold

@xpivarc i see that the test test_id:5004 failed on every run for the job pull-kubevirt-e2e-k8s-1.18 on the latest commit, could you take a look, please?

I think it should be in QUARANTINE, see #5908

@xpivarc
Copy link
Member Author

xpivarc commented Jun 23, 2021 •
edited

@itamarh FYI
@iholder-redhat

@dhiller
Copy link
Contributor

dhiller commented Jun 23, 2021

Hm, could also be a flake according to ci search: https://search.ci.kubevirt.io/?search=test_id%3A5004&maxAge=336h&context=1&type=bug%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job

@fgimenez do you know?

@dhiller
Copy link
Contributor

dhiller commented Jun 23, 2021

Hm, could also be a flake according to ci search: https://search.ci.kubevirt.io/?search=test_id%3A5004&maxAge=336h&context=1&type=bug%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job

@fgimenez do you know?

Nevermind.

@dhiller
Copy link
Contributor

dhiller commented Jun 23, 2021

/override pull-kubevirt-e2e-k8s-1.18

@kubevirt-bot
Copy link
Contributor

@dhiller: Overrode contexts on behalf of dhiller: pull-kubevirt-e2e-k8s-1.18

In response to this:

/override pull-kubevirt-e2e-k8s-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhiller
Copy link
Contributor

dhiller commented Jun 23, 2021

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2021
@xpivarc
Copy link
Member Author

xpivarc commented Jun 23, 2021

@dhiller Thanks!

@iholder101
Copy link
Contributor

@dhiller @xpivarc Sorry guys, I had this #5895 PR going on to try to see if 5004 passed, therefore I removed the quarantine tag. Eventually I wanted to get the quarantine back, merge the PR, and see the the periodics don't fail for 14 days. I didn't noticed that this PR got approved and merged. Therefore immediately merged this #5908.

Sorry for the inconvenience. I should /hold such PRs from now on.

@dhiller
Copy link
Contributor

dhiller commented Jun 23, 2021

/retest

@kubevirt-bot kubevirt-bot merged commit 7d028c8 into kubevirt:release-0.41 Jun 23, 2021
@kubevirt-bot kubevirt-bot mentioned this pull request Jun 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhiller dhiller dhiller approved these changes

@maiqueb maiqueb Awaiting requested review from maiqueb

@yuhaohaoyu yuhaohaoyu Awaiting requested review from yuhaohaoyu

Assignees

@dhiller dhiller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xpivarc @dhiller @ashleyschuett @kubevirt-bot @kubevirt-commenter-bot @iholder101