migration: only remove migration-specific metadata from libvirt XML #5989
Conversation
Removing the whole kubevirt metadata bloc can cause issues with existing code Signed-off-by: Jed Lejosne <jed@redhat.com>
kubevirt-bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stu-gott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/cherry-pick release-0.41 |
|
@stu-gott: once the present PR merges, I will cherry-pick it on top of release-0.41 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@stu-gott: new pull request created: #6016 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Removing the whole kubevirt metadata bloc on migration can cause issues with existing code.
This PR limits the removal to only the migration section.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1966903
Special notes for your reviewer:
Release note: