CDI to 1.36.0 which and add support for DataSource #6029
Conversation
kubevirt-bot
added
release-note
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
|
/retest |
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
|
/hold cancel |
kubevirt-bot
removed
the
do-not-merge/hold
|
/retest |
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
| return nil, err | ||
| } | ||
| if cloneSource.Namespace == "" { | ||
| cloneSource.Namespace = ar.Namespace |
There was a problem hiding this comment.
Can ar.Namespace be ""? I don't think so, and if it cannot be blank, then the check on line 170 can skip the cloneSource.Name == "" part.
There was a problem hiding this comment.
Technically I think you are correct. Will update if there are any other changes requested
|
/retest |
| Expect(err).ToNot(HaveOccurred()) | ||
| Expect(causes).To(BeEmpty()) | ||
| }, | ||
| table.Entry("when source namespace suppied", "ns1", "", "", "ns3", "", "ns3", "ns1", "default"), |
There was a problem hiding this comment.
/lgtm
missing "l" in all supplied refs
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Signed-off-by: Michael Henriksen mhenriks@redhat.com
What this PR does / why we need it:
Add support for CDI DataSOurce API.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: