Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.41] Generate ISO images 4k aligned for node storage with 4k blocksize #6157

Merged
merged 1 commit into from Aug 17, 2021
Merged

[release-0.41] Generate ISO images 4k aligned for node storage with 4k blocksize #6157

merged 1 commit into from Aug 17, 2021

Conversation

enp0s3
Copy link
Contributor

@enp0s3 enp0s3 commented Jul 29, 2021

Manual cherry-pick of #5806

Signed-off-by: Igor Bezukh ibezukh@redhat.com

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1976730

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 29, 2021
@enp0s3
Copy link
Contributor Author

enp0s3 commented Jul 29, 2021

/cc @mlsorensen @rmohr

rmohr
rmohr requested changes Jul 29, 2021
View reviewed changes
Copy link
Member

@rmohr rmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enp0s3 I think you will also have to pull in #5990 or some tests will be flaky under certain circumstances.

@enp0s3
Copy link
Contributor Author

enp0s3 commented Jul 29, 2021

#6158

@enp0s3 I think you will also have to pull in #5990 or some tests will be flaky under certain circumstances.

@rmohr Thank you. I've created #6158

@rmohr
Copy link
Member

rmohr commented Jul 29, 2021

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2021
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2021
@enp0s3
Manual cherry-pick of kubevirt#5806
8606a7b 
[release-0.41] Generate ISO images 4k aligned for node storage with 4k blocksize

Signed-off-by: Igor Bezukh <ibezukh@redhat.com>
@kubevirt-bot kubevirt-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 2, 2021
@dankenigsberg
Copy link
Member

/test pull-kubevirt-e2e-k8s-1.18-0.41

@enp0s3
Copy link
Contributor Author

enp0s3 commented Aug 4, 2021

/hold
Let's wait till #6184 will land. It should resolve the flakiness of test_id:5004

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2021
@enp0s3
Copy link
Contributor Author

enp0s3 commented Aug 11, 2021

/override pull-kubevirt-e2e-k8s-1.18

test_id:5004 and test_id:1663 were quarantined in main branch. I've ran them locally with the PR rebase and they have passed. In addition, this PR merged in main and didn't affect these tests stability. Therefore I will override the lane.

@enp0s3
Copy link
Contributor Author

enp0s3 commented Aug 11, 2021

/unhold
Since this is an important fix for the cases where the nodes are using 4k block size storage, I will unhold the PR and will take care about backporting tests stability PRs in parallel to this PR.

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2021
@kubevirt-bot
Copy link
Contributor

@enp0s3: Overrode contexts on behalf of enp0s3: pull-kubevirt-e2e-k8s-1.18

In response to this:

/override pull-kubevirt-e2e-k8s-1.18

test_id:5004 and test_id:1663 were quarantined in main branch. I've ran them locally with the PR rebase and they have passed. In addition, this PR merged in main and didn't affect these tests stability. Therefore I will override the lane.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stu-gott
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2021
@kubevirt-bot kubevirt-bot merged commit 6a7e371 into kubevirt:release-0.41 Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmohr rmohr rmohr requested changes

@ILpinto ILpinto Awaiting requested review from ILpinto

@maiqueb maiqueb Awaiting requested review from maiqueb

@mlsorensen mlsorensen Awaiting requested review from mlsorensen

Assignees

@rmohr rmohr

@stu-gott stu-gott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@enp0s3 @rmohr @kubevirt-bot @kubevirt-commenter-bot @dankenigsberg @stu-gott