Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.41] fix goroutine leak in virt-handler #6227

Merged
merged 1 commit into from Aug 24, 2021
Merged

[release-0.41] fix goroutine leak in virt-handler #6227

merged 1 commit into from Aug 24, 2021

Conversation

kwiesmueller
Copy link

@kwiesmueller kwiesmueller commented Aug 10, 2021 •
edited

This is an modified version of #6176 for compatibility with Go 1.13.

/assign @kwiesmueller

Fix goroutine leak in virt-handler, potentially causing issues with a high turnover of VMIs.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Aug 10, 2021
@kwiesmueller kwiesmueller changed the title [release-0.42] fix goroutine leak in virt-handler [release-0.41] fix goroutine leak in virt-handler Aug 10, 2021
@kwiesmueller
Copy link
Author

/assign @jean-edouard

@kwiesmueller
Copy link
Author

/cherrypick release-0.40

@kubevirt-bot
Copy link
Contributor

@kwiesmueller: once the present PR merges, I will cherry-pick it on top of release-0.40 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.40

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwiesmueller
Copy link
Author

/cherrypick release-0.39

@kubevirt-bot
Copy link
Contributor

@kwiesmueller: once the present PR merges, I will cherry-pick it on top of release-0.39 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.39

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwiesmueller
Copy link
Author

/cherrypick release-0.38

@kubevirt-bot
Copy link
Contributor

@kwiesmueller: once the present PR merges, I will cherry-pick it on top of release-0.38 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.38

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwiesmueller
Copy link
Author

/cherrypick release-0.37

@kubevirt-bot
Copy link
Contributor

@kwiesmueller: once the present PR merges, I will cherry-pick it on top of release-0.37 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.37

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwiesmueller
Copy link
Author

/cherrypick release-0.36

@kubevirt-bot
Copy link
Contributor

@kwiesmueller: once the present PR merges, I will cherry-pick it on top of release-0.36 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwiesmueller
Copy link
Author

/retest

davidvossel
davidvossel approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2021
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

4 similar comments
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

10 similar comments
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fix goroutine leak in virt-handler
61bfe78 
Signed-off-by: Kevin Wiesmueller <kwiesmul@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021
@kwiesmueller
Copy link
Author

Rebased to see if we can get that one test passing.

@kwiesmueller
Copy link
Author

I'm having a hard time understanding why this test is failing and why it's only 1.18 🤔

@jean-edouard
Copy link
Contributor

/lgtm
/override pull-kubevirt-e2e-k8s-1.18

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2021
@kubevirt-bot
Copy link
Contributor

@jean-edouard: Overrode contexts on behalf of jean-edouard: pull-kubevirt-e2e-k8s-1.18

In response to this:

/lgtm
/override pull-kubevirt-e2e-k8s-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit f6fd763 into kubevirt:release-0.41 Aug 24, 2021
@kubevirt-bot
Copy link
Contributor

@kwiesmueller: new pull request created: #6287

In response to this:

/cherrypick release-0.40

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Aug 24, 2021
Merged
@kubevirt-bot
Copy link
Contributor

@kwiesmueller: new pull request created: #6288

In response to this:

/cherrypick release-0.39

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 24, 2021
Closed
Closed
@kubevirt-bot
Copy link
Contributor

@kwiesmueller: new pull request created: #6289

In response to this:

/cherrypick release-0.38

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Aug 24, 2021
Closed
@kubevirt-bot
Copy link
Contributor

@kwiesmueller: new pull request created: #6290

In response to this:

/cherrypick release-0.37

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Aug 24, 2021
Merged
@kubevirt-bot
Copy link
Contributor

@kwiesmueller: new pull request created: #6291

In response to this:

/cherrypick release-0.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel davidvossel approved these changes

@dhiller dhiller Awaiting requested review from dhiller

@phoracek phoracek Awaiting requested review from phoracek

Assignees

@davidvossel davidvossel

@jean-edouard jean-edouard

@kwiesmueller kwiesmueller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kwiesmueller @kubevirt-bot @kubevirt-commenter-bot @jean-edouard @davidvossel