Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.41] bug 1982143 -Change volume not supporting snapshot status error #6320

Merged
merged 1 commit into from Sep 7, 2021
Merged

[release-0.41] bug 1982143 -Change volume not supporting snapshot status error #6320

merged 1 commit into from Sep 7, 2021

Conversation

ShellyKa13
Copy link
Contributor

This is a cherry-pick of #6282

Release note:

NONE

@ShellyKa13
Change volume not supporting snapshot status error
8d59094 
the volume snapshot status for volumes types which doesnt support
snapshot was wrong, its not because they are lacking storage class
as was the previous error they dont need it at all they simply dont
support snapshot.
fix bug 1982143

Signed-off-by: Shelly Kagan <skagan@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Aug 30, 2021
@ShellyKa13 ShellyKa13 changed the title [release-0.41] Change volume not supporting snapshot status error [release-0.41] bug 1982143 -Change volume not supporting snapshot status error Aug 31, 2021
@ShellyKa13
Copy link
Contributor Author

/retest

@kubevirt-bot
Copy link
Contributor

@ShellyKa13: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-kubevirt-e2e-k8s-1.20-sig-network-0.41
  • /test pull-kubevirt-e2e-k8s-1.20-sig-storage-0.41
  • /test pull-kubevirt-e2e-k8s-1.19-0.41
  • /test pull-kubevirt-e2e-k8s-1.19-sig-network-0.41
  • /test pull-kubevirt-e2e-k8s-1.19-sig-storage-0.41
  • /test pull-kubevirt-e2e-k8s-1.19-sig-compute-0.41
  • /test pull-kubevirt-e2e-k8s-1.19-operator-0.41
  • /test pull-kubevirt-e2e-k8s-1.18-0.41
  • /test pull-kubevirt-e2e-windows2016-0.41
  • /test pull-kubevirt-e2e-kind-1.17-sriov-0.41
  • /test pull-kubevirt-e2e-k8s-1.17-rook-ceph-0.41
  • /test pull-kubevirt-generate-0.41
  • /test pull-kubevirt-build-0.41
  • /test pull-kubevirt-build-arm64-0.41
  • /test pull-kubevirt-unit-test-0.41
  • /test pull-kubevirt-apidocs-0.41
  • /test pull-kubevirt-client-python-0.41
  • /test pull-kubevirt-manifests-0.41
  • /test pull-kubevirt-prom-rules-verify-0.41

The following commands are available to trigger optional jobs:

  • /test pull-kubevirt-e2e-k8s-1.20-0.41
  • /test pull-kubevirt-e2e-k8s-1.20-sig-compute-0.41
  • /test pull-kubevirt-e2e-k8s-1.20-operator-0.41
  • /test pull-kubevirt-e2e-k8s-1.20-cgroupsv2-0.41
  • /test pull-kubevirt-e2e-k8s-1.19-nonroot-0.41
  • /test pull-kubevirt-e2e-k8s-1.17-0.41
  • /test pull-kubevirt-e2e-kind-1.17-sriov-nonroot-0.41
  • /test pull-kubevirt-check-tests-for-flakes-0.41
  • /test pull-kubevirt-e2e-k8s-1.17-rook-ceph-nonroot-0.41
  • /test pull-kubevirt-e2e-k8s-1.20-rook-ceph-0.41
  • /test pull-kubevirt-verify-rpms-0.41
  • /test pull-kubevirt-gosec-0.41
  • /test pull-kubevirt-goveralls-0.41

Use /test all to run the following jobs that were automatically triggered:

  • pull-kubevirt-e2e-k8s-1.20-sig-network-0.41
  • pull-kubevirt-e2e-k8s-1.20-sig-storage-0.41
  • pull-kubevirt-e2e-k8s-1.19-0.41
  • pull-kubevirt-e2e-k8s-1.19-sig-network-0.41
  • pull-kubevirt-e2e-k8s-1.19-sig-storage-0.41
  • pull-kubevirt-e2e-k8s-1.19-sig-compute-0.41
  • pull-kubevirt-e2e-k8s-1.19-operator-0.41
  • pull-kubevirt-e2e-k8s-1.18-0.41
  • pull-kubevirt-e2e-windows2016-0.41
  • pull-kubevirt-e2e-kind-1.17-sriov-0.41
  • pull-kubevirt-check-tests-for-flakes-0.41
  • pull-kubevirt-e2e-k8s-1.17-rook-ceph-0.41
  • pull-kubevirt-generate-0.41
  • pull-kubevirt-build-0.41
  • pull-kubevirt-build-arm64-0.41
  • pull-kubevirt-unit-test-0.41
  • pull-kubevirt-apidocs-0.41
  • pull-kubevirt-client-python-0.41
  • pull-kubevirt-manifests-0.41
  • pull-kubevirt-prom-rules-verify-0.41

In response to this:

/test pull-kubevirt-e2e-k8s-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShellyKa13
Copy link
Contributor Author

/restest

@ShellyKa13
Copy link
Contributor Author

/retest

3 similar comments
@ShellyKa13
Copy link
Contributor Author

/retest

@mhenriks
Copy link
Member

mhenriks commented Sep 2, 2021

/retest

@ShellyKa13
Copy link
Contributor Author

/retest

@rmohr
Copy link
Member

rmohr commented Sep 6, 2021

/lgtm
/approve

@mhenriks feel free to make use of your approver status on storage related backporting PRs.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2021
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

6 similar comments
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@rmohr
Copy link
Member

rmohr commented Sep 7, 2021

/override pull-kubevirt-e2e-k8s-1.18

@kubevirt-bot
Copy link
Contributor

@rmohr: Overrode contexts on behalf of rmohr: pull-kubevirt-e2e-k8s-1.18

In response to this:

/override pull-kubevirt-e2e-k8s-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit b78af0e into kubevirt:release-0.41 Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleyschuett ashleyschuett Awaiting requested review from ashleyschuett

@vatsalparekh vatsalparekh Awaiting requested review from vatsalparekh

Assignees

@rmohr rmohr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ShellyKa13 @kubevirt-bot @mhenriks @rmohr @kubevirt-commenter-bot