Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release-0.44] Move host-disk to handler #6357

Merged
merged 2 commits into from Sep 9, 2021
Merged

[Release-0.44] Move host-disk to handler #6357

merged 2 commits into from Sep 9, 2021

Conversation

xpivarc
Copy link
Member

@xpivarc xpivarc commented Sep 6, 2021 •
edited

What this PR does / why we need it:
This is backport of #6240

This moves the responsibility of creating disks to virt-handler. It is needed for rootless virt-launcher

BZ #https://bugzilla.redhat.com/show_bug.cgi?id=2001984

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Sep 6, 2021
@xpivarc
Copy link
Member Author

xpivarc commented Sep 7, 2021

/retest
/cc @davidvossel

@jean-edouard
Copy link
Contributor

This backport of #6240 also sneaks in most of #6233.
Could we maybe explicitly backport the commits from both PRs, to avoid future confusion?
Also, when cherry-picking, please use -x to keep a link to the original commits.

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 8, 2021
@kubevirt-bot @xpivarc
Merge pull request kubevirt#6233 from xpivarc/fix-host-disk-unit-test
fe515b6 
Fix host disk unit test

(cherry picked from commit 5703265)
Signed-off-by: L. Pivarc <lpivarc@redhat.com>
@kubevirt-bot @xpivarc
Merge pull request kubevirt#6240 from xpivarc/nr-move-host-disk-to-ha…
4217e70 
…ndler

Move host-disk to handler

(cherry picked from commit c5ded0d)
Signed-off-by: L. Pivarc <lpivarc@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Sep 8, 2021
jean-edouard
jean-edouard reviewed Sep 8, 2021
View reviewed changes
Copy link
Contributor

@jean-edouard jean-edouard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jean-edouard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@xpivarc
Copy link
Member Author

xpivarc commented Sep 9, 2021

/retest

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Sep 9, 2021 •
edited

@xpivarc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-kubevirt-check-tests-for-flakes 4217e70 link /test pull-kubevirt-check-tests-for-flakes-0.44

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

davidvossel
davidvossel reviewed Sep 9, 2021
View reviewed changes
Copy link
Member

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021
@kubevirt-bot kubevirt-bot merged commit 0909b21 into kubevirt:release-0.44 Sep 9, 2021
@kubevirt-bot kubevirt-bot mentioned this pull request Sep 13, 2021
Merged
@kubevirt-bot kubevirt-bot mentioned this pull request Nov 2, 2021
Closed
@kubevirt-bot kubevirt-bot mentioned this pull request Nov 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel davidvossel left review comments

@jean-edouard jean-edouard jean-edouard left review comments

@ILpinto ILpinto Awaiting requested review from ILpinto

Assignees

@davidvossel davidvossel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xpivarc @jean-edouard @kubevirt-bot @davidvossel