Ignore "didn't find PVC associated with DataVolume" spurious warning #6407
Conversation
kubevirt-bot
added
release-note-none
maya-r
force-pushed
the
spurious-pvc-not-found
branch
from
1242f37
to
9217eff
Compare
kubevirt-bot
added
size/XS
and removed
lgtm
|
/lgtm |
This allows us to match warnings that contain a reference to an object with a generated name. Signed-off-by: Maya Rashish <mrashish@redhat.com>
The VMI can be created before CDI creates a PVC, resulting in this spurious warning. Signed-off-by: Maya Rashish <mrashish@redhat.com>
maya-r
force-pushed
the
spurious-pvc-not-found
branch
from
9217eff
to
4aefd4e
Compare
maya-r
changed the title
| WaitForSuccessfulVMIStartWithTimeout(obj, timeout) | ||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| defer cancel() | ||
| warningsIgnoreList := []string{"didn't find PVC associated with DataVolume"} |
There was a problem hiding this comment.
ah, i don't think this will work because the warning is a strict match of this string, and not just checking if the warning contains the substring.
Maybe the utils.go funciton that's comparing warnings should use strings.Contains() instead of == in the shouldIgnoreWarning() function
|
/lgtm looks like the sriov lane still isn't matching the warning correctly. maybe they have something else going on there that's causing an issue though. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest |
|
/retest |
which can happen before DV success and is normal.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Example failure
Special notes for your reviewer:
Release note: