Fix deprecated use of watch API

[VirrageS]

What this PR does / why we need it: This MR fixes a problem that leads to reporting incorrect metrics in Kubernetes. The problem is that watchFunc uses deprecated (since K8s v1.12) API call which seems to be incorrectly interpreted by apiserver. My fix is simply replacing old, deprecated method of indicating WATCH operation by a new one. After the fix the apiserver_request_duration_seconds metrics for LIST operation drop to normal levels:

Which issue(s) this PR fixes:
Fixes #6436

Special notes for your reviewer: None

Release note:

Fix deprecated use of watch API to prevent reporting incorrect metrics.

[kubevirt-bot]

Hi @VirrageS. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rthallisey]

/lgtm

[rthallisey]

/ok-to-test

[rthallisey]

/retest

[rthallisey]

/retest

[rmohr]

/approve

Nice small change.

[rmohr]

/retest

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rmohr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubevirt-commenter-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[kubevirt-commenter-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.