Virtctl - Force Bind the PVC on WFFC storage #6513

brybacki · 2021-10-04T15:21:59Z

What this PR does / why we need it:

A new option for imageupload is available - force-bind. This will force
the scheduling of a CDI worker pod and immediately bind the PVC
ignoring the WaitForFirstConsumer logic.

This is useful for use cases that do not require binding to a particular
node (like uploading a golden image to the cluster).

It uses the annotation added here: kubevirt/containerized-data-importer#1560

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Adds force-bind flag to virtctl imageupload

A new option for imageupload is available - force-bind. This will force the scheduling of a CDI worker pod and immediately bind the PVC ignoring the WaitForFirstConsumer logic. This is useful for use cases that do not require binding to a particular node (like uploading a golden image to the cluster). Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>

ShellyKa13 · 2021-10-04T15:31:51Z

/lgtm

brybacki · 2021-10-05T06:14:45Z

/retest

pkg/virtctl/imageupload/imageupload.go

Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>

zcahana · 2021-10-05T10:32:13Z

/lgtm

brybacki · 2021-10-05T11:52:05Z

looks like a new flake test:
Tests Suite: [sig-storage] Storage Starting a VirtualMachineInstance with error disk should pause VMI on IO error expand_more
/test pull-kubevirt-e2e-k8s-1.22-sig-storag

kubevirt-bot · 2021-10-05T11:52:07Z

@brybacki: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-kubevirt-e2e-k8s-1.21-sig-network
/test pull-kubevirt-e2e-k8s-1.21-sig-storage
/test pull-kubevirt-e2e-k8s-1.21-sig-compute
/test pull-kubevirt-e2e-k8s-1.21-operator
/test pull-kubevirt-e2e-k8s-1.20-sig-network
/test pull-kubevirt-e2e-k8s-1.20-sig-compute
/test pull-kubevirt-e2e-k8s-1.20-operator
/test pull-kubevirt-e2e-k8s-1.20-sig-compute-nonroot
/test pull-kubevirt-e2e-k8s-1.20-operator-nonroot
/test pull-kubevirt-e2e-k8s-1.19-sig-network
/test pull-kubevirt-e2e-k8s-1.19-sig-compute
/test pull-kubevirt-e2e-k8s-1.19-operator
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.19-sriov
/test pull-kubevirt-e2e-kind-1.19-vgpu
/test pull-kubevirt-generate
/test pull-kubevirt-build
/test pull-kubevirt-build-arm64
/test pull-kubevirt-unit-test
/test pull-kubevirt-apidocs
/test pull-kubevirt-client-python
/test pull-kubevirt-manifests
/test pull-kubevirt-prom-rules-verify
/test pull-kubevirt-check-unassigned-tests

The following commands are available to trigger optional jobs:

/test pull-kubevirt-e2e-k8s-1.21-rest-coverage
/test pull-kubevirt-e2e-k8s-1.20-sig-storage
/test pull-kubevirt-e2e-k8s-1.20-cgroupsv2
/test pull-kubevirt-e2e-k8s-1.20-sig-network-nonroot
/test pull-kubevirt-e2e-k8s-1.20-sig-storage-nonroot
/test pull-kubevirt-e2e-k8s-1.19-sig-storage
/test pull-kubevirt-e2e-kind-1.19-sriov-nonroot
/test pull-kubevirt-check-tests-for-flakes
/test pull-kubevirt-verify-rpms
/test pull-kubevirt-verify-go-mod
/test pull-kubevirt-gosec
/test pull-kubevirt-goveralls
/test pull-kubevirt-fossa
/test pull-kubevirt-e2e-k8s-1.22-sig-network
/test pull-kubevirt-e2e-k8s-1.22-sig-storage
/test pull-kubevirt-e2e-k8s-1.22-sig-compute
/test pull-kubevirt-e2e-k8s-1.22-operator
/test pull-kubevirt-e2e-k8s-1.22-sig-compute-realtime

Use /test all to run the following jobs that were automatically triggered:

pull-kubevirt-e2e-k8s-1.21-sig-network
pull-kubevirt-e2e-k8s-1.21-sig-storage
pull-kubevirt-e2e-k8s-1.21-sig-compute
pull-kubevirt-e2e-k8s-1.21-operator
pull-kubevirt-e2e-k8s-1.20-sig-network
pull-kubevirt-e2e-k8s-1.20-sig-compute
pull-kubevirt-e2e-k8s-1.20-operator
pull-kubevirt-e2e-k8s-1.20-sig-compute-nonroot
pull-kubevirt-e2e-k8s-1.20-operator-nonroot
pull-kubevirt-e2e-k8s-1.19-sig-network
pull-kubevirt-e2e-k8s-1.19-sig-compute
pull-kubevirt-e2e-k8s-1.19-operator
pull-kubevirt-e2e-windows2016
pull-kubevirt-e2e-kind-1.19-sriov
pull-kubevirt-e2e-kind-1.19-vgpu
pull-kubevirt-check-tests-for-flakes
pull-kubevirt-generate
pull-kubevirt-build
pull-kubevirt-build-arm64
pull-kubevirt-unit-test
pull-kubevirt-goveralls
pull-kubevirt-fossa
pull-kubevirt-apidocs
pull-kubevirt-client-python
pull-kubevirt-manifests
pull-kubevirt-prom-rules-verify
pull-kubevirt-check-unassigned-tests
pull-kubevirt-e2e-k8s-1.22-sig-network
pull-kubevirt-e2e-k8s-1.22-sig-storage
pull-kubevirt-e2e-k8s-1.22-sig-compute
pull-kubevirt-e2e-k8s-1.22-operator

In response to this:

looks like a new flake test:
Tests Suite: [sig-storage] Storage Starting a VirtualMachineInstance with error disk should pause VMI on IO error expand_more
/test pull-kubevirt-e2e-k8s-1.22-sig-storag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

brybacki · 2021-10-05T13:56:32Z

/test pull-kubevirt-e2e-k8s-1.22-sig-storage

brybacki · 2021-10-06T07:28:36Z

/retest

brybacki · 2021-10-06T10:10:05Z

/retest

rmohr

Looks good content-weise but I would encourage to add more unit-tests and e2e tests in this area.

pkg/virtctl/imageupload/imageupload.go

brybacki · 2021-10-13T15:53:02Z

/retest

tests/storage/imageupload.go

Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>

rmohr

/lgtm
/approve

rmohr · 2021-10-26T07:15:46Z

tests/storage/imageupload.go

+
+	Context("Create upload volume with force-bind flag", func() {
+		DescribeTable("Should succeed", func(resource, targetName string, validateFunc func(string), deleteFunc func(string)) {
+			defer deleteFunc(targetName)


Not sure if this defer is needed, but it does not hurt either.

kubevirt-bot · 2021-10-26T07:16:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rmohr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot · 2021-10-26T12:34:02Z

@brybacki: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubevirt-e2e-arm64	`4261682`	link	false	`/test pull-kubevirt-e2e-arm64`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

brybacki · 2021-10-26T12:51:02Z

/retest

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Oct 4, 2021

kubevirt-bot requested review from acardace and zcahana October 4, 2021 15:22

kubevirt-bot assigned ShellyKa13 Oct 4, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2021

zcahana reviewed Oct 5, 2021

View reviewed changes

pkg/virtctl/imageupload/imageupload.go Show resolved Hide resolved

pkg/virtctl/imageupload/imageupload.go Outdated Show resolved Hide resolved

Correct force-bind flag description

36f9448

Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2021

kubevirt-bot assigned zcahana Oct 5, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2021

rmohr requested changes Oct 12, 2021

View reviewed changes

pkg/virtctl/imageupload/imageupload.go Show resolved Hide resolved

kubevirt-bot assigned rmohr Oct 12, 2021

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2021

brybacki force-pushed the virtctl-force-bind branch from 4261682 to a10b0a4 Compare October 25, 2021 10:48

kubevirt-bot added size/L and removed size/M labels Oct 25, 2021

rmohr requested changes Oct 25, 2021

View reviewed changes

tests/storage/imageupload.go Outdated Show resolved Hide resolved

Test force-bind annotation

edba3fe

Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>

brybacki force-pushed the virtctl-force-bind branch from a10b0a4 to edba3fe Compare October 25, 2021 11:58

brybacki mentioned this pull request Oct 26, 2021

WaitForFirstCustomer and --image-upload do not work well together #4601

Closed

rmohr approved these changes Oct 26, 2021

View reviewed changes

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2021

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2021

kubevirt-bot merged commit f3e648c into kubevirt:main Oct 26, 2021

brybacki deleted the virtctl-force-bind branch October 27, 2021 08:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Virtctl - Force Bind the PVC on WFFC storage #6513

Virtctl - Force Bind the PVC on WFFC storage #6513

brybacki commented Oct 4, 2021 •

edited

ShellyKa13 commented Oct 4, 2021

brybacki commented Oct 5, 2021

zcahana commented Oct 5, 2021

brybacki commented Oct 5, 2021

kubevirt-bot commented Oct 5, 2021

brybacki commented Oct 5, 2021

brybacki commented Oct 6, 2021

brybacki commented Oct 6, 2021

rmohr left a comment

brybacki commented Oct 13, 2021

rmohr left a comment

rmohr Oct 26, 2021

kubevirt-bot commented Oct 26, 2021

kubevirt-bot commented Oct 26, 2021 •

edited

brybacki commented Oct 26, 2021

Virtctl - Force Bind the PVC on WFFC storage #6513

Virtctl - Force Bind the PVC on WFFC storage #6513

Conversation

brybacki commented Oct 4, 2021 • edited

ShellyKa13 commented Oct 4, 2021

brybacki commented Oct 5, 2021

zcahana commented Oct 5, 2021

brybacki commented Oct 5, 2021

kubevirt-bot commented Oct 5, 2021

brybacki commented Oct 5, 2021

brybacki commented Oct 6, 2021

brybacki commented Oct 6, 2021

rmohr left a comment

Choose a reason for hiding this comment

brybacki commented Oct 13, 2021

rmohr left a comment

Choose a reason for hiding this comment

rmohr Oct 26, 2021

Choose a reason for hiding this comment

kubevirt-bot commented Oct 26, 2021

kubevirt-bot commented Oct 26, 2021 • edited

brybacki commented Oct 26, 2021

brybacki commented Oct 4, 2021 •

edited

kubevirt-bot commented Oct 26, 2021 •

edited