Include hotplugged disks in online VM snapshot #6642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
ShellyKa13
force-pushed
the
include-hot-plug-in-vm-snapshot
branch
from
08340d6
to
867b49e
Compare
ShellyKa13
force-pushed
the
include-hot-plug-in-vm-snapshot
branch
from
867b49e
to
43b39c1
Compare
|
/retest |
mhenriks
reviewed
Oct 21, 2021
| @@ -228,6 +200,13 @@ func (s *vmSnapshotSource) Spec() (snapshotv1.SourceSpec, error) { | |||
| annotations[k] = v | |||
| } | |||
| vmCpy.ObjectMeta.Annotations = annotations | |||
| vmi, exists, err := s.controller.getVMI(s.vm) | |||
| if err != nil || !exists { | |||
| return snapshotv1.SourceSpec{}, err | |||
There was a problem hiding this comment.
Is it possible that the VMI no longer exists? If so, returning an empty spec the right thing to do?
There was a problem hiding this comment.
you are right I should return error if !exists
|
I love that this is net fewer lines! |
ShellyKa13
force-pushed
the
include-hot-plug-in-vm-snapshot
branch
from
43b39c1
to
096c2d5
Compare
|
/retest |
kubevirt-bot
added
the
needs-rebase
Signed-off-by: Shelly Kagan <skagan@redhat.com>
Remove the check and the constraint of can't do vm snapshot with hotplug disks, instead include the persistent volumes in the snapshot so those will be restored in compared to unpersistent disks which will not be included in the snapshot and the restore. Signed-off-by: Shelly Kagan <skagan@redhat.com>
ShellyKa13
force-pushed
the
include-hot-plug-in-vm-snapshot
branch
from
096c2d5
to
ed4cb12
Compare
kubevirt-bot
removed
the
needs-rebase
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: