Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passing the tests images registry on Kubevirt Conformance plugin #6651

Merged
merged 2 commits into from Oct 21, 2021

Conversation

ormergi
Copy link
Contributor

@ormergi ormergi commented Oct 20, 2021

What this PR does / why we need it:
Following #6199,
we see errors on the last periodic-kubevirt-push-nightly-conformance job
junit log show that images are being pulled from quay.io/kubevirt instead of the local registry:

Failed to pull image \"quay.io/kubevirt/cirros-container-disk-demo:devel\": rpc error: code = Unknown desc = Error reading manifest devel in quay.io/kubevirt/cirros-container-disk-demo: manifest unknown: manifest unknown"
Kubevirt Conformance test suite pulls images from quay.io/kubevirt by default.

This PR add support for passing DOCKER_PREFIX to the plugin test suite.
It will enable pulling images from other registries including local registry.

This PR also set make conformance to pull from the local registry by default.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Kubevirt Conformance plugin now supports passing tests images registry.

Signed-off-by: Or Mergi <ormergi@redhat.com>
Kubevirt Conformance test suite pulls images
from quay.io/kubevirt by default.

This commit add support for passing DOCKER_PREFIX
to the plugin test suite.

It will enable pulling images from other registries
including local registry.

Signed-off-by: Or Mergi <ormergi@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Oct 20, 2021
@ormergi
Copy link
Contributor Author

ormergi commented Oct 20, 2021

/cc @rmohr @phoracek

@rmohr
Copy link
Member

rmohr commented Oct 20, 2021

/lgtm
/approve

/hold

@ormergi feel free to unhold when you tested the relevant flows. Code is fine.

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2021
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2021
@ormergi
Copy link
Contributor Author

ormergi commented Oct 20, 2021

@ormergi feel free to unhold when you tested the relevant flows. Code is fine.

Thanks 🙂
I verified the following flows:

  • automation/conformance.sh
  • make cluster-up cluster-sync conformace
  • # from kubevirtci
    make cluster-up
    version=$(curl -L  curl -L https://storage.googleapis.com/kubevirt-prow/devel/nightly/release/kubevirt/kubevirt/latest)
    kubectl apply -f https://storage.googleapis.com/kubevirt-prow/devel/nightly/release/kubevirt/kubevirt/$versionkubevirt-operator.yaml
    kubectl apply -f https://storage.googleapis.com/kubevirt-prow/devel/nightly/release/kubevirt/kubevirt/$version/kubevirt-cr.yaml
    sonobuoy run --wait --e2e-repo-config kubevirtci/hack/confromance-image-config.yaml --plugin https://storage.googleapis.com/kubevirt-prow/devel/nightly/release/kubevirt/$versionconformance.yaml
    

On all flows the correct images were used.

@ormergi
Copy link
Contributor Author

ormergi commented Oct 20, 2021

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2021
@ormergi
Copy link
Contributor Author

ormergi commented Oct 20, 2021

/test pull-kubevirt-e2e-k8s-1.21-sig-compute

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants