New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for passing the tests images registry on Kubevirt Conformance plugin #6651
Add support for passing the tests images registry on Kubevirt Conformance plugin #6651
Conversation
Signed-off-by: Or Mergi <ormergi@redhat.com>
Kubevirt Conformance test suite pulls images from quay.io/kubevirt by default. This commit add support for passing DOCKER_PREFIX to the plugin test suite. It will enable pulling images from other registries including local registry. Signed-off-by: Or Mergi <ormergi@redhat.com>
/lgtm /hold @ormergi feel free to unhold when you tested the relevant flows. Code is fine. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rmohr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks 🙂
On all flows the correct images were used. |
/unhold |
/test pull-kubevirt-e2e-k8s-1.21-sig-compute |
/retest |
What this PR does / why we need it:
Following #6199,
we see errors on the last periodic-kubevirt-push-nightly-conformance job
junit log show that images are being pulled from
quay.io/kubevirt
instead of the local registry:This PR add support for passing
DOCKER_PREFIX
to the plugin test suite.It will enable pulling images from other registries including local registry.
This PR also set
make conformance
to pull from the local registry by default.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: