Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm: Update libvirt and QEMU #6657

Merged
merged 6 commits into from Oct 27, 2021
Merged

rpm: Update libvirt and QEMU #6657

merged 6 commits into from Oct 27, 2021

Conversation

andreabolognani
Copy link
Contributor

What this PR does / why we need it:

Updates libvirt and QEMU. Specifically:

  • libvirt 7.0.0-14 → 7.6.0-4
  • QEMU 5.2.0-16 → 6.0.0-31

Special notes for your reviewer:

The new version of libvirt contains changes that are necessary for #6162 along with the usual bug fixes and improvements.

Release note:

This version of KubeVirt includes upgraded virtualization technology based on libvirt 7.6.0 and QEMU 6.0.0.
Each new release of libvirt and QEMU contains numerous improvements and bug fixes.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Oct 20, 2021
@rmohr
Copy link
Member

rmohr commented Oct 21, 2021

Oh:

unsupported configuration: USB redirection is not supported by this version of QEMU

@andreabolognani
Copy link
Contributor Author

unsupported configuration: USB redirection is not supported by this version of QEMU

@rmohr I think some component that used to depend on usbredir either downgraded that dependency it to a weak one, which IIRC bazeldnf will ignore, or dropped it altogether.

The fix might be as simple as explicitly including usbredir in the launcherbase image, but I need to look into the situation and figure out whether this change was intentional or something that needs to be reverted.

@alicefr
Copy link
Member

alicefr commented Oct 25, 2021

@andreabolognani any chances to get this fix included :). This is needed by #6672

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2021
@andreabolognani
rpm: Update packages
e66c548 
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
@andreabolognani
rpm: Simplify ignores for libguestfs image
f631dc0 
If we ignore the libvirt-daemon-kvm package, which is a
meta-package that brings in not only the QEMU driver but also
a number of other things that we don't care about in the
context of KubeVirt, we can simplify things a bit.

In addition to that, there are a few more ignores that we can
drop without affecting the results.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
@andreabolognani
rpm: Update libvirt and QEMU
cd13a35 
Specifically:

  libvirt 7.0.0-14 -> 7.6.0-4
     QEMU 5.2.0-16 -> 6.0.0-33

Note that we have to add the qemu-kvm-hw-usbredir subpackage
explicitly to the launcherbase image now, as the qemu-kvm-core
subpackage no longer comes with usbredir support built-in.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
@andreabolognani
rpm: Pin QEMU version everywhere
252cd25 
Currently testimage will end up with some random version of
qemu-img: probably the latest one, but possibly not the same
one as launcherbase.

This will not necessarily cause any problem, but it's nicer
to use the same version everywhere. It also saves on download
time during build and disk usage for the artifact mirror.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
@andreabolognani
rpm: Further simplify ignores for libguestfs image
885d81e 
qemu-kvm-core no longer drags in usbredir, so ignoring it
explicitly has become unnecessary.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
@andreabolognani
vendor: Update libvirt.org/go/libvirt
e7896ee 
This new version of the Go bindings was released along with
libvirt 7.6.0; the version number is v1.7005.1 rather than
v1.7006.0 because it introduces no API changes.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
@kubevirt-bot kubevirt-bot added size/XXL and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L labels Oct 26, 2021
@andreabolognani
Copy link
Contributor Author

@rmohr I have confirmed that the usbredir change was intentional: qemu-kvm-core no longer depends on it, which makes sense considering that it's supposed to be a minimal runtime package. The fix is simple enough - just add the newly-introduced qemu-kvm-hw-usbredir into the mix.

@alicefr The fix you're looking for is included in libvirt-7.6.0-5, but unfortunately we can only use libvirt-7.6.0-4 because the more recent build, despite having completed successfully, is not published in the AV repo. I'll ask around and try to figure out why it doesn't show up.

/retest

@andreabolognani
Copy link
Contributor Author

/retest

@andreabolognani
Copy link
Contributor Author

@rmohr All tests have passed. Can you please approve the MR? Thanks! :)

@rmohr
Copy link
Member

rmohr commented Oct 27, 2021

/lgtm
/approve

looks awesome. 🎆

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 27, 2021
@andreabolognani
Copy link
Contributor Author

/retest

1 similar comment
@andreabolognani
Copy link
Contributor Author

/retest

@kubevirt-bot kubevirt-bot merged commit 03c314a into kubevirt:main Oct 27, 2021
@andreabolognani andreabolognani deleted the virt-update branch October 28, 2021 07:37
@andreabolognani andreabolognani mentioned this pull request Oct 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiqueb maiqueb Awaiting requested review from maiqueb

@stu-gott stu-gott Awaiting requested review from stu-gott

Assignees

@rmohr rmohr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andreabolognani @rmohr @alicefr @kubevirt-bot