Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests suite reporter: Collect guest VM cloud-init logs #6882

Merged
merged 1 commit into from Dec 18, 2021
Merged

tests suite reporter: Collect guest VM cloud-init logs #6882

merged 1 commit into from Dec 18, 2021

Conversation

ormergi
Copy link
Contributor

@ormergi ormergi commented Nov 29, 2021 •
edited

Signed-off-by: Or Mergi ormergi@redhat.com

What this PR does / why we need it:
With this PR test suite reporter will collect cloud-init logs from guest VM's from failing tests
and save them at artifacts/cloud-init/vmis.

Having those logs will help debugging failing tests due to cloud-init configuration failures.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
This PR changes will help with working on #6776

Release note:

NONE

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M labels Nov 29, 2021
@ormergi
tests, reporter: Collect guest VM cloud-init logs
f2d8b37 
Signed-off-by: Or Mergi <ormergi@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 30, 2021
maya-r
maya-r reviewed Dec 1, 2021
View reviewed changes
tests/reporter/kubernetes.go
@@ -1115,6 +1174,37 @@ func (r *KubernetesReporter) executePriviledgedVirtLauncherCommands(virtCli kube
}
}

func (r *KubernetesReporter) executeCloudInitCommands(vmi v12.VirtualMachineInstance, path string, vmiType string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file could use better names for functions, but I guess it is consistent with existing usage and it is best handled in a separate PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I am planning to post small refactoring PR for this file soon, we can do it then 🙂

@maya-r
Copy link
Contributor

maya-r commented Dec 1, 2021

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2021
@ormergi
Copy link
Contributor Author

ormergi commented Dec 1, 2021

/cc @enp0s3 hey could you please take a look? 🙂

@ormergi
Copy link
Contributor Author

ormergi commented Dec 1, 2021

/hold
I will remove it when finish verifying that we get the files we need

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2021
@ormergi
Copy link
Contributor Author

ormergi commented Dec 1, 2021

/unhold
Verified by failing one of the tests on local environment, we get the cloud-init logs as expected

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2021
@ormergi
Copy link
Contributor Author

ormergi commented Dec 1, 2021

/retest

@ormergi
Copy link
Contributor Author

ormergi commented Dec 1, 2021

/cc @qinqon @enp0s3

@rmohr
Copy link
Member

rmohr commented Dec 15, 2021

/cc @rmohr

@rmohr
Copy link
Member

rmohr commented Dec 15, 2021

/approve

Looks useful 👍

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@ormergi
Copy link
Contributor Author

ormergi commented Dec 16, 2021

Thank you 🙂

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

4 similar comments
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit e4fbb54 into kubevirt:main Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maya-r maya-r maya-r left review comments

@kbidarkar kbidarkar Awaiting requested review from kbidarkar

@rnetser rnetser Awaiting requested review from rnetser

@enp0s3 enp0s3 Awaiting requested review from enp0s3

@qinqon qinqon Awaiting requested review from qinqon

@rmohr rmohr Awaiting requested review from rmohr

Assignees

@maya-r maya-r

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ormergi @maya-r @rmohr @kubevirt-bot @kubevirt-commenter-bot