add kubectl_test to arm64 e2e test suit #6979
Conversation
kubevirt-bot
added
release-note-none
|
verify if pull-kubevirt-e2e-arm64 CI test works well |
|
/retest pull-kubevirt-e2e-arm64 |
|
@zhlhahaha: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubevirt-e2e-arm64 |
1 similar comment
|
/test pull-kubevirt-e2e-arm64 |
|
/test pull-kubevirt-e2e-arm64 |
|
/retest |
|
/test pull-kubevirt-e2e-arm64 |
kubevirt-bot
added
needs-rebase
kubevirt-bot
added
size/M
and removed
size/S
needs-rebase
|
/test pull-kubevirt-e2e-arm64 |
|
/test pull-kubevirt-e2e-arm64 |
2 similar comments
|
/test pull-kubevirt-e2e-arm64 |
|
/test pull-kubevirt-e2e-arm64 |
|
/test pull-kubevirt-e2e-arm64 |
|
/retest |
|
/test pull-kubevirt-e2e-arm64 |
|
/test pull-kubevirt-e2e-arm64 |
|
/test pull-kubevirt-e2e-arm64 |
|
CC: @rmohr |
|
/lgtm |
tests/framework/checks/skips.go
Outdated
| schedulableNodesNum := len(nodes.Items) | ||
| if schedulableNodesNum < nodeCount { | ||
| msg := fmt.Sprintf( | ||
| "no enough Schedulable node: expected %v nodes, but got %v", |
There was a problem hiding this comment.
| "no enough Schedulable node: expected %v nodes, but got %v", | |
| "skipping due to not enough Schedulable nodes: tes requires %v nodes, but got %v", |
| @@ -1216,6 +1217,9 @@ spec: | |||
| }), | |||
| table.Entry("[test_id:6308] daemonsets", | |||
| func() { | |||
| // When only have one node, updating virt-hander would get following error | |||
| // "Unable to mark node as unschedulable" | |||
There was a problem hiding this comment.
Could you explain that a little bit? I would expect that we can update virt-handler without issues and I can't see where we are setting the node to unschedulable.
There was a problem hiding this comment.
Hi Roman, I did more investigation on it. If I only test test_id:6308, it would pass, but when I test both test_id:6256 and test_id:6308 on a one-node k8s cluster, the tests get fail. Test test_id:6308 restarts virt-hander, but virt-hander fail to start with following error message:
{"Unable to mark node as unschedulable":"nodes \"$(NODE_NAME)\" not found","component":"virt-handler","level":"error","pos":"virt-handler.go:175","timestamp":"2022-04-15T02:05:23.421281Z"}
And I use ps aux to see the command of virt-hander, it shows
virt-handler --port 8443 --hostname-override $(NODE_NAME) --pod-ip-address $(MY_POD_IP) --max-metric-requests 3 --console-server-port 8186 --graceful-shutdown-seconds 315 -v 2
NODE_NAME and MY_POD_IP does not have correct value. It seems that NODE_NAME is failed to get value from spec.nodeName.
containerEnv := []corev1.EnvVar{
{
Name: "NODE_NAME",
ValueFrom: &corev1.EnvVarSource{
FieldRef: &corev1.ObjectFieldSelector{
FieldPath: "spec.nodeName",
},
},
},
{
Name: "MY_POD_IP",
ValueFrom: &corev1.EnvVarSource{
FieldRef: &corev1.ObjectFieldSelector{
FieldPath: "status.podIP",
},
},
},
}
Any suggestion?
tests/operator_test.go
Outdated
| @@ -2229,6 +2239,7 @@ spec: | |||
| Context("With PrometheusRule Enabled", func() { | |||
|
|
|||
| BeforeEach(func() { | |||
| tests.SkipIfARM64("Currently not works on Arm64") | |||
There was a problem hiding this comment.
Could you rephrase these:
| tests.SkipIfARM64("Currently not works on Arm64") | |
| tests.SkipIfARM64("Currently not supported on arm64") |
|
@zhlhahaha: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubevirt-bot
added
the
needs-rebase
kubectl_test operator_test Signed-off-by: Howard Zhang <howard.zhang@arm.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@zhlhahaha: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
kubevirt-bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
kubevirt-bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. /close |
|
@kubevirt-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Release note: