Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default container annotation to Pod #7288

Merged
merged 1 commit into from Mar 4, 2022
Merged

Add default container annotation to Pod #7288

merged 1 commit into from Mar 4, 2022

Conversation

raspbeep
Copy link

What this PR does / why we need it:
Add default container annotation to virt-launcher Pod for kubectl logs <vmi-pod> to display logs without specifying container.

Special notes for your reviewer:

Release note:

Users now don't need to specify container for `kubectl logs <vmi-pod>` and `kubectl exec <vmi-pod>`.

Add default container annotation to Pod
9ea85a2 
Signed-off-by: Pavel Kratochvil <pakratoc@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XL needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 28, 2022
@kubevirt-bot
Copy link
Contributor

Hi @raspbeep. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xpivarc
Copy link
Member

xpivarc commented Feb 28, 2022

/retest

2 similar comments
@xpivarc
Copy link
Member

xpivarc commented Feb 28, 2022

/retest

@xpivarc
Copy link
Member

xpivarc commented Feb 28, 2022

/retest

jean-edouard
jean-edouard reviewed Mar 2, 2022
View reviewed changes
Copy link
Contributor

@jean-edouard jean-edouard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thanks!

pkg/virt-controller/services/template_test.go
Expect(pod.ObjectMeta.Annotations).To(Not(HaveKey(key)))
}
},
table.Entry("and don't contain kubectl annotation",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/don't/not/

pkg/virt-controller/services/template_test.go
"kubectl.kubernetes.io/last-applied-configuration": "open",
},
),
table.Entry("and don't contain kubevirt annotation added by apiserver",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/don't/not/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: these are really minor spelling observations, it's ok if they don't get fixed.
Let's have someone else review and LGTM this PR.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jean-edouard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@rmohr
Copy link
Member

rmohr commented Mar 3, 2022

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022
@rmohr
Copy link
Member

rmohr commented Mar 4, 2022

/ok-to-test
/retest

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2022
@rmohr
Copy link
Member

rmohr commented Mar 4, 2022

/retest

@kubevirt-bot kubevirt-bot merged commit 0945077 into kubevirt:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jean-edouard jean-edouard jean-edouard left review comments

@rnetser rnetser Awaiting requested review from rnetser

Assignees

@rmohr rmohr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@raspbeep @kubevirt-bot @xpivarc @rmohr @jean-edouard