Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virt-operator, webhooks: add validation for WorkloadUpdateMethods #7406

Merged
merged 1 commit into from Apr 9, 2022
Merged

virt-operator, webhooks: add validation for WorkloadUpdateMethods #7406

merged 1 commit into from Apr 9, 2022

Conversation

acardace
Copy link
Member

What this PR does / why we need it:

Let's make sure we reject LiveMigrate as a WorkloadUpdateMethod when the LiveMigration feature gate is not enabled.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Reject `LiveMigrate` as a workload-update strategy if the `LiveMigration` feature gate is not enabled.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Mar 18, 2022
@acardace acardace force-pushed the validate-workload-update-methods branch 2 times, most recently from 876b0af to 7a65c7f Compare March 25, 2022 10:03
@acardace acardace mentioned this pull request Mar 25, 2022
Closed
@acardace
Copy link
Member Author

/retest

maiqueb
maiqueb suggested changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions.

pkg/virt-operator/webhooks/kubevirt-update-admitter_test.go Outdated Show resolved Hide resolved
pkg/virt-operator/webhooks/kubevirt-update-admitter_test.go Outdated Show resolved Hide resolved
@acardace acardace force-pushed the validate-workload-update-methods branch from 7a65c7f to f8f10b9 Compare March 29, 2022 14:58
@acardace acardace requested a review from maiqueb March 29, 2022 15:00
maiqueb
maiqueb approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

I think the test now read very well.

I left an opinionated nit you're free to ignore.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@acardace acardace force-pushed the validate-workload-update-methods branch from f8f10b9 to f04ca7f Compare March 29, 2022 15:57
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@acardace
virt-operator, webhooks: add validation for WorkloadUpdateMethods
789e20b 
Make sure we reject `LiveMigrate` as a WorkloadUpdateMethod when the
`LiveMigration` feature gate is not enabled.

Signed-off-by: Antonio Cardace <acardace@redhat.com>
@acardace acardace force-pushed the validate-workload-update-methods branch from f04ca7f to 789e20b Compare March 29, 2022 16:15
maiqueb
maiqueb approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@acardace
Copy link
Member Author

/retest

davidvossel
davidvossel reviewed Apr 8, 2022
View reviewed changes
Copy link
Member

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2022
@acardace
Copy link
Member Author

acardace commented Apr 8, 2022

/retest

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit ad621ac into kubevirt:main Apr 9, 2022
@kubevirt-bot kubevirt-bot mentioned this pull request Apr 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel davidvossel left review comments

@maiqueb maiqueb maiqueb approved these changes

@EdDev EdDev Awaiting requested review from EdDev

Assignees

@maiqueb maiqueb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@acardace @kubevirt-bot @kubevirt-commenter-bot @davidvossel @maiqueb