Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.53] Handle virtctl guestfs incorrectly assuming image name, grant access to /guestfs endpoint #7726

Merged
merged 2 commits into from May 20, 2022
Merged

[release-0.53] Handle virtctl guestfs incorrectly assuming image name, grant access to /guestfs endpoint #7726

merged 2 commits into from May 20, 2022

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #7592

/assign akalenyu

BugFix: virtctl guestfs incorrectly assumes image name

@akalenyu
Handle virtctl guestfs incorrectly assuming image name
a1e8370 
Handle a case where we were discarding a possible image name prefix in virtctl guestfs.
BZ #2068905.

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@akalenyu
Add permissions for /guestfs and make generate
1351efc 
We want unprivileged users to be able to make this GET,
otherwise they can't infer the guestfs image.

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 11, 2022
@kubevirt-bot kubevirt-bot mentioned this pull request May 11, 2022
Merged
@akalenyu
Copy link
Contributor

/retest

3 similar comments
@akalenyu
Copy link
Contributor

/retest

@akalenyu
Copy link
Contributor

/retest

@akalenyu
Copy link
Contributor

/retest

@xpivarc
Copy link
Member

xpivarc commented May 17, 2022

/approve
/cc @alicefr @mhenriks

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2022
@alicefr
Copy link
Member

alicefr commented May 20, 2022

/lgtm
thanks @akalenyu

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2022
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot
Copy link
Contributor Author

kubevirt-bot commented May 20, 2022 •
edited

@kubevirt-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-k8s-1.23-sig-storage 1351efc link true /test pull-kubevirt-e2e-k8s-1.23-sig-storage-0.53

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 1feee2c into kubevirt:release-0.53 May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbidarkar kbidarkar Awaiting requested review from kbidarkar

@rmohr rmohr Awaiting requested review from rmohr

@alicefr alicefr Awaiting requested review from alicefr

@mhenriks mhenriks Awaiting requested review from mhenriks

Assignees

@alicefr alicefr

@akalenyu akalenyu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kubevirt-bot @akalenyu @xpivarc @alicefr @kubevirt-commenter-bot