Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.53] Backport 'Fix vm restore in case of restore size bigger then PVC requested size' #7941

Merged
merged 2 commits into from Jun 23, 2022
Merged

[release-0.53] Backport 'Fix vm restore in case of restore size bigger then PVC requested size' #7941

merged 2 commits into from Jun 23, 2022

Conversation

akalenyu
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://bugzilla.redhat.com/show_bug.cgi?id=2086825

Special notes for your reviewer:

Release note:

BugFix: Fix vm restore in case of restore size bigger then PVC requested size

@ShellyKa13 @akalenyu
Make the snapshot controller impement volumeSnapshotProvider interface
6b7d6b4 
This interface will be used in the restore controller
to get the volume snapshot.

Signed-off-by: Shelly Kagan <skagan@redhat.com>
@ShellyKa13 @akalenyu
Update restore PVC to the restore size if it is bigger then pvc size
e3d7b16 
This should fix a case where the restore size is bigger then
the pvc request size so when trying to restore to the pvc
the restore fails.

Signed-off-by: Shelly Kagan <skagan@redhat.com>
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 19, 2022
@akalenyu akalenyu mentioned this pull request Jun 19, 2022
Closed
@akalenyu
Copy link
Contributor Author

/retest

1 similar comment
@ShellyKa13
Copy link
Contributor

/retest

enp0s3
enp0s3 approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2022
@akalenyu
Copy link
Contributor Author

/retest

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Jun 23, 2022 •
edited

@akalenyu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-k8s-1.21-sig-performance e3d7b16 link false /test pull-kubevirt-e2e-k8s-1.21-sig-performance-0.53

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 2ee1c71 into kubevirt:release-0.53 Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enp0s3 enp0s3 enp0s3 approved these changes

@rnetser rnetser Awaiting requested review from rnetser

Assignees

@enp0s3 enp0s3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@akalenyu @ShellyKa13 @kubevirt-bot @kubevirt-commenter-bot @enp0s3