Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.49]Fixing host model support heterogeneus cluster #7953

Merged
merged 2 commits into from Jul 18, 2022
Merged

[release-0.49]Fixing host model support heterogeneus cluster #7953

merged 2 commits into from Jul 18, 2022

Conversation

Barakmor1
Copy link
Member

@Barakmor1 Barakmor1 commented Jun 20, 2022 •
edited

What this PR does / why we need it:
Calculate selectors only for the initial Node to remeber the required features,
allow vmi with host-model to migrate when target node does't have the same host-model cpuModel.
manual backporting #7672 ,#7770 from main
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

bmordeha added 2 commits June 20, 2022 12:42
Calculate selectors only for the initial Node to remeber the required…
668e636 
… features,

Allow vmi with host-model to migrate when target node does't have the same host-model cpuModel.
Manual back port kubevirt#7672,kubevirt#7770 from main

Signed-off-by: bmordeha <bmodeha@redhat.com>
Add functional tests to test the modifiactions of the back port.
59e6b04 
Modify existing tests to consider the new changes of the back port.

Signed-off-by: bmordeha <bmodeha@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Jun 20, 2022
@Barakmor1
Copy link
Member Author

/retest

2 similar comments
@Barakmor1
Copy link
Member Author

/retest

@Barakmor1
Copy link
Member Author

/retest

@Barakmor1 Barakmor1 changed the title Fixing host model support heterogeneus cluster [release-0.49] [release-0.49]Fixing host model support heterogeneus cluster Jun 21, 2022
@Barakmor1 Barakmor1 mentioned this pull request Jun 21, 2022
Closed
enp0s3
enp0s3 approved these changes Jul 17, 2022
View reviewed changes
Copy link
Contributor

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2022
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@Barakmor1
Copy link
Member Author

/retest

1 similar comment
@Barakmor1
Copy link
Member Author

/retest

@kubevirt-bot kubevirt-bot merged commit 5498a5f into kubevirt:release-0.49 Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enp0s3 enp0s3 enp0s3 approved these changes

@ILpinto ILpinto Awaiting requested review from ILpinto

@zcahana zcahana Awaiting requested review from zcahana

Assignees

@enp0s3 enp0s3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Barakmor1 @kubevirt-bot @kubevirt-commenter-bot @enp0s3