Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.44] Backport 'Fix vm restore in case of restore size bigger then PVC requested size' #7985

Merged

Conversation

ShellyKa13
Copy link
Contributor

What this PR does / why we need it:
This is a manual cherry pick of PR #7933

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://bugzilla.redhat.com/show_bug.cgi?id=2101174

Special notes for your reviewer:

Release note:

BugFix: Fix vm restore in case of restore size bigger then PVC requested size

This interface will be used in the restore controller
to get the volume snapshot.

Signed-off-by: Shelly Kagan <skagan@redhat.com>
This should fix a case where the restore size is bigger then
the pvc request size so when trying to restore to the pvc
the restore fails.

Signed-off-by: Shelly Kagan <skagan@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Jun 26, 2022
@ShellyKa13
Copy link
Contributor Author

/retest

1 similar comment
@ShellyKa13
Copy link
Contributor Author

/retest

@alicefr
Copy link
Member

alicefr commented Jun 27, 2022

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2022
@ShellyKa13
Copy link
Contributor Author

/retest

2 similar comments
@ShellyKa13
Copy link
Contributor Author

/retest

@ShellyKa13
Copy link
Contributor Author

/retest

@kubevirt-bot
Copy link
Contributor

@ShellyKa13: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-k8s-1.21-sig-network ddb3ed2 link false /test pull-kubevirt-e2e-k8s-1.21-sig-network-0.44

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mhenriks
Copy link
Member

/approve

@mhenriks
Copy link
Member

/retest

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022
@kubevirt-bot kubevirt-bot merged commit afb1525 into kubevirt:release-0.44 Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants