Add Windows VM tests #809

cynepco3hahue · 2018-03-12T15:41:12Z

Requirments for Windows VM testing:

must exist disk-windows PVC that bounded to some PV
will need to start pod that includes winrm-cli tool

Tests:

Start Windows VM
Stop Windows VM
Verify that Windows VM has correct UUID
Verify that Windows VM has pod IP

Signed-off-by: Lukianov Artyom alukiano@redhat.com

cynepco3hahue · 2018-03-13T17:19:35Z

Start and stop windows VM tests passed, working on other tests.

stu-gott

Looks good so far!

stu-gott · 2018-03-13T18:15:56Z

tests/windows_test.go

+import (
+	"flag"
+	"fmt"
+	//"time"


remove commented module

sure will remove it

stu-gott · 2018-03-13T18:20:18Z

tests/windows_test.go

+			)
+		})
+
+		XIt("should have correct UUID", func() {


The X means "skip", right?

Yes, I still trying to make work exec command via API, so I disable this tests ro run locally until it will work.

rmohr

I would have preferred the possibility to directly talk to windows from within our code with winrm, but it is a good start to create this extra container.

rmohr · 2018-03-14T10:51:40Z

images/winrmcli/Dockerfile

+# Copyright 2018 Red Hat, Inc.
+#
+
+FROM golang:1.6


I wonder how we can provide winrm-cli without having to pull in anoter image which is not fedora:27.

I will check if we have the possibility to bring fedora 27 with go inside

rmohr · 2018-03-14T10:52:40Z

tests/windows_test.go

+	tests.BeforeAll(func() {
+		windowsPv, err := virtClient.CoreV1().PersistentVolumes().Get(tests.DiskWindows, metav1.GetOptions{})
+		if err != nil {
+			Skip(fmt.Sprintf("Skip Windows tests that requires PVC %s", tests.DiskWindows))


We could create a helper which is called something like SkipIfNoWindowsImage() and isolate the logic in utils.go

Can't we call this in a BeforeEach block? The BeforeAll is a not so well done extension for Ginkgo by us.

will create a separate helper

yes I know, I just wanted to avoid calling to Kube API for each test, it just relevant for all windows tests
@rmohr Do you have some objections vs BeforeAll, I checked ginkgo issue and the only objections vs it, was the possibility to run tests in parallel, but for windows testing, we can't run in parallel anyway(without test code changes)

rmohr · 2018-03-14T10:55:10Z

tests/windows_test.go

+		if err != nil {
+			Skip(fmt.Sprintf("Skip Windows tests that requires PVC %s", tests.DiskWindows))
+		}
+		windowsPv.Spec.ClaimRef = nil


What does this do?

I assume that before testing we already added windows PV to the cluster, and maybe it already used by some PVC(currently not), so the PV will have the state Released, but new PVC still cannot use it(https://kubernetes.io/docs/concepts/storage/persistent-volumes/#retain), so I remove ClaimRef to move it to Available state(I checked via google, looks it acceptable action that does not do any harm to the cluster).
I think I will check on PV state, if it has Released state I will remove ClaimRef, otherwise will skip windows tests.

cynepco3hahue

In general I also more like API usage instead of calling to pod exec command, but currently we run tests outside of the cluster and we do not have the possibility to reach VM

cynepco3hahue · 2018-03-14T11:17:23Z

images/winrmcli/Dockerfile

+# Copyright 2018 Red Hat, Inc.
+#
+
+FROM golang:1.6


I will check if we have the possibility to bring fedora 27 with go inside

cynepco3hahue · 2018-03-14T11:21:43Z

tests/windows_test.go

+	tests.BeforeAll(func() {
+		windowsPv, err := virtClient.CoreV1().PersistentVolumes().Get(tests.DiskWindows, metav1.GetOptions{})
+		if err != nil {
+			Skip(fmt.Sprintf("Skip Windows tests that requires PVC %s", tests.DiskWindows))


will create a separate helper

yes I know, I just wanted to avoid calling to Kube API for each test, it just relevant for all windows tests
@rmohr Do you have some objections vs BeforeAll, I checked ginkgo issue and the only objections vs it, was the possibility to run tests in parallel, but for windows testing, we can't run in parallel anyway(without test code changes)

cynepco3hahue · 2018-03-14T11:26:31Z

tests/windows_test.go

+		if err != nil {
+			Skip(fmt.Sprintf("Skip Windows tests that requires PVC %s", tests.DiskWindows))
+		}
+		windowsPv.Spec.ClaimRef = nil


I assume that before testing we already added windows PV to the cluster, and maybe it already used by some PVC(currently not), so the PV will have the state Released, but new PVC still cannot use it(https://kubernetes.io/docs/concepts/storage/persistent-volumes/#retain), so I remove ClaimRef to move it to Available state(I checked via google, looks it acceptable action that does not do any harm to the cluster).
I think I will check on PV state, if it has Released state I will remove ClaimRef, otherwise will skip windows tests.

cynepco3hahue · 2018-03-14T13:14:43Z

Passed fine on my environment 😄

Running Suite: Tests Suite
==========================
Random Seed: 1521032584
Will run 4 of 64 specs

SSSSSSSSSSSSSSSSSSSSSSSSSSS
------------------------------
• [SLOW TEST:109.742 seconds]
Windows VM
/root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:54
  should success to start
  /root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:128
------------------------------
• [SLOW TEST:39.100 seconds]
Windows VM
/root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:54
  should success to stop
  /root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:134
------------------------------
• [SLOW TEST:237.837 seconds]
Windows VM
/root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:54
  with winrm connection
  /root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:145
    should have correct UUID
    /root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:185
------------------------------
• [SLOW TEST:219.764 seconds]
Windows VM                                                                                                                                                
/root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:54
  with winrm connection
  /root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:145
    should have pod IP
    /root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:201

cynepco3hahue · 2018-03-21T18:50:19Z

I ran it on nested environment and it looks pretty good 😄

./automation/test.sh 
+ export WORKSPACE=/home/alukiano/go/src/kubevirt.io/kubevirt
+ WORKSPACE=/home/alukiano/go/src/kubevirt.io/kubevirt
+ export PROVIDER=k8s-1.9.3
+ PROVIDER=k8s-1.9.3
+ export VAGRANT_NUM_NODES=1
+ VAGRANT_NUM_NODES=1
+ export NAMESPACE=kube-system
+ NAMESPACE=kube-system
+ trap '{ make cluster-down; }' EXIT
+ make cluster-down
./cluster/down.sh
+ NFS_SERVER=nfs
+ NFS_WINDOWS_DIR=/home/alukiano/Downloads/windows2016_images/qe_image
...
Waiting for rsyncd to be ready
rsync: safe_read failed to read 1 bytes [sender]: Connection reset by peer (104)
rsync error: error in rsync protocol data stream (code 12) at io.c(276) [sender=3.1.3]
Waiting for rsyncd to be ready
skipping directory .
go version go1.9.2 linux/amd64
Compiling tests...
    compiled tests.test
a68ea9e93176f3722987df3a3db20c6cb4e7790f78eb890da4c9de83be5fc63a
a68ea9e93176f3722987df3a3db20c6cb4e7790f78eb890da4c9de83be5fc63a
hack/functests.sh
Running Suite: Tests Suite
==========================
Random Seed: 1521657006
Will run 4 of 66 specs

SSSSSSSSSSSSSSSSSSSSSSSSSSSSS
------------------------------
• [SLOW TEST:14.475 seconds]
Windows VM
/root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:54
  should success to start
  /root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:128
------------------------------
• [SLOW TEST:13.016 seconds]
Windows VM
/root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:54
  should success to stop
  /root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:134
------------------------------
• [SLOW TEST:149.177 seconds]
Windows VM
/root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:54
  with winrm connection
  /root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:145
    should have correct UUID
    /root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:185
------------------------------
• [SLOW TEST:204.675 seconds]
Windows VM
/root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:54
  with winrm connection
  /root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:145
    should have pod IP
    /root/go/src/kubevirt.io/kubevirt/tests/windows_test.go:201
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
Waiting for namespace kubevirt-test-default to be removed, this can take a while ...
Waiting for namespace kubevirt-test-alternative to be removed, this can take a while ...

Ran 4 of 66 Specs in 424.611 seconds
SUCCESS! -- 4 Passed | 0 Failed | 0 Pending | 62 Skipped PASS
+ make cluster-down
./cluster/down.sh

Will see how does it will work on CI.

cynepco3hahue · 2018-03-22T06:51:13Z

@rmohr I ran it on CI host and unexpectedly it all passed with pretty good times(almost the same as on my environment) 😄

cynepco3hahue · 2018-03-26T08:24:00Z

retest this please

cynepco3hahue · 2018-03-26T14:18:03Z

Here we go https://rfenkhuber.fedorapeople.org/jenkins/10/windows-console.log 😄

rmohr

Some minor changes requests.

rmohr · 2018-04-03T10:06:01Z

tests/windows_test.go

+			Expect(output).Should(ContainSubstring(strings.ToUpper(windowsFirmware)))
+		}, 360)
+
+		It("should have pod IP", func() {


Instead of fetching the pod, you can simply wait for the vm to run and look up the ip from its status.

rmohr · 2018-04-03T10:07:32Z

tests/windows_test.go

+		tests.WaitForSuccessfulVMStartWithTimeout(vm, 180)
+	}, 300)
+
+	It("should success to stop", func() {


It("should succeed to stop a running vm"), By("Strating the vm"), By ("Stopping the vm")

rmohr · 2018-04-03T10:08:00Z

tests/windows_test.go

+		windowsVm.Spec = windowsVmSpec
+	})
+
+	It("should success to start", func() {


It("should succeed to start a vm")

rmohr · 2018-04-03T10:10:49Z

tests/windows_test.go

+		var cli []string
+		var output string
+
+		BeforeEach(func() {


Ok I am convinced now that the BeforeAll which we have should also be good enough in this case.

To test Windows VM we need to create additional pod that will have winrm-cli tool. Tests: - Start Windows VM - Stop Windows VM - Verify that Windows VM has correct UUID - Verify that Windows VM has pod IP Signed-off-by: Lukianov Artyom <alukiano@redhat.com>

Signed-off-by: Lukianov Artyom <alukiano@redhat.com>

rmohr

Looks good now. Once the windows image is in place again we can rerun a last time and then merge.

cynepco3hahue · 2018-04-07T16:23:37Z

@rmohr Passed fine https://rfenkhuber.fedorapeople.org/jenkins/1/windows-console.log

Adding code to not allow importing from registry when contenType is not kubevirt

cynepco3hahue changed the title ~~[WIP] Add Windows VM tests~~ [Skip CI][WIP] Add Windows VM tests Mar 12, 2018

cynepco3hahue force-pushed the windows_tests branch from d102c4b to 30ad695 Compare March 13, 2018 17:14

stu-gott reviewed Mar 13, 2018

View reviewed changes

cynepco3hahue changed the title ~~[Skip CI][WIP] Add Windows VM tests~~ [WIP] Add Windows VM tests Mar 14, 2018

cynepco3hahue force-pushed the windows_tests branch from d67bde9 to 0454222 Compare March 14, 2018 09:39

cynepco3hahue changed the title ~~[WIP] Add Windows VM tests~~ Add Windows VM tests Mar 14, 2018

rmohr requested changes Mar 14, 2018

View reviewed changes

cynepco3hahue commented Mar 14, 2018

View reviewed changes

cynepco3hahue force-pushed the windows_tests branch from 0454222 to 1107854 Compare March 14, 2018 13:13

cynepco3hahue force-pushed the windows_tests branch from 1107854 to 7c2a559 Compare March 14, 2018 15:28

cynepco3hahue force-pushed the windows_tests branch from 7c2a559 to e3482cc Compare March 21, 2018 18:45

cynepco3hahue force-pushed the windows_tests branch 6 times, most recently from 6219815 to 39e342e Compare March 26, 2018 14:05

cynepco3hahue force-pushed the windows_tests branch from 39e342e to 7a751a2 Compare March 27, 2018 07:08

rmohr requested changes Apr 3, 2018

View reviewed changes

cynepco3hahue force-pushed the windows_tests branch from 7a751a2 to a6bfeb8 Compare April 4, 2018 15:11

[WIP] Add Windows VM tests

020be81

To test Windows VM we need to create additional pod that will have winrm-cli tool. Tests: - Start Windows VM - Stop Windows VM - Verify that Windows VM has correct UUID - Verify that Windows VM has pod IP Signed-off-by: Lukianov Artyom <alukiano@redhat.com>

cynepco3hahue force-pushed the windows_tests branch from a6bfeb8 to 9692f91 Compare April 4, 2018 15:20

Make work command execution from winrmcli pod

428b051

Signed-off-by: Lukianov Artyom <alukiano@redhat.com>

cynepco3hahue force-pushed the windows_tests branch from 9692f91 to 428b051 Compare April 4, 2018 16:23

rmohr reviewed Apr 6, 2018

View reviewed changes

rmohr approved these changes Apr 8, 2018

View reviewed changes

rmohr merged commit e83802d into kubevirt:master Apr 8, 2018

cynepco3hahue deleted the windows_tests branch April 12, 2018 12:25

kubevirt-bot pushed a commit to kubevirt-bot/kubevirt that referenced this pull request Nov 6, 2020

Merge pull request kubevirt#809 from zvikorn/issue-808

43dc792

Adding code to not allow importing from registry when contenType is not kubevirt

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Windows VM tests #809

Add Windows VM tests #809

cynepco3hahue commented Mar 12, 2018

cynepco3hahue commented Mar 13, 2018

stu-gott left a comment

stu-gott Mar 13, 2018

cynepco3hahue Mar 13, 2018

stu-gott Mar 13, 2018

cynepco3hahue Mar 13, 2018 •

edited

rmohr left a comment

rmohr Mar 14, 2018

cynepco3hahue Mar 14, 2018

rmohr Mar 14, 2018

rmohr Mar 14, 2018

cynepco3hahue Mar 14, 2018 •

edited

rmohr Mar 14, 2018

cynepco3hahue Mar 14, 2018

cynepco3hahue left a comment

cynepco3hahue Mar 14, 2018

cynepco3hahue Mar 14, 2018 •

edited

cynepco3hahue Mar 14, 2018

cynepco3hahue commented Mar 14, 2018

cynepco3hahue commented Mar 21, 2018

cynepco3hahue commented Mar 22, 2018

cynepco3hahue commented Mar 26, 2018

cynepco3hahue commented Mar 26, 2018

rmohr left a comment

rmohr Apr 3, 2018

cynepco3hahue Apr 4, 2018

rmohr Apr 3, 2018

cynepco3hahue Apr 4, 2018

rmohr Apr 3, 2018

cynepco3hahue Apr 4, 2018

rmohr Apr 3, 2018

rmohr left a comment

cynepco3hahue commented Apr 7, 2018

Add Windows VM tests #809

Add Windows VM tests #809

Conversation

cynepco3hahue commented Mar 12, 2018

cynepco3hahue commented Mar 13, 2018

stu-gott left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cynepco3hahue Mar 13, 2018 • edited

Choose a reason for hiding this comment

rmohr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cynepco3hahue Mar 14, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cynepco3hahue left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cynepco3hahue Mar 14, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cynepco3hahue commented Mar 14, 2018

cynepco3hahue commented Mar 21, 2018

cynepco3hahue commented Mar 22, 2018

cynepco3hahue commented Mar 26, 2018

cynepco3hahue commented Mar 26, 2018

rmohr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rmohr left a comment

Choose a reason for hiding this comment

cynepco3hahue commented Apr 7, 2018

cynepco3hahue Mar 13, 2018 •

edited

cynepco3hahue Mar 14, 2018 •

edited

cynepco3hahue Mar 14, 2018 •

edited