add validations for spec.topologySpreadConstraints

[alaypatel07]

Signed-off-by: Alay Patel alayp@nvidia.com

What this PR does / why we need it:

This PR adds validation for spec.topologySpreadConstraints field which was introduced in #7846

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8250

Special notes for your reviewer:

Release note:

add server-side validations for spec.topologySpreadConstraints during object creation

[kubevirt-bot]

Hi @alaypatel07. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vasiliy-ul]

/ok-to-test

[vasiliy-ul]

Would it make sense to create a function that sets the given TopologySpreadConstraints for the vmi? The above code seems to be used in all the tests. This will reduce duplication.

[alaypatel07]

I think so, will update

[alaypatel07]

@vasiliy-ul I see that a lot of code duplication is happening due to

			ar := &admissionv1.AdmissionReview{
				Request: &admissionv1.AdmissionRequest{
					Resource: webhooks.VirtualMachineInstanceGroupVersionResource,
					Object: runtime.RawExtension{
						Raw: vmiBytes,
					},
				},
			}

			resp := vmiCreateAdmitter.Admit(ar)

And that is across all the tests. Since the scope of that is larger, can I take that up in a follow up cleanup PR? or may be address in #8239

[vasiliy-ul]

Still, I would consider creating a local helper function within the topologySpreadConstraints context scope with the following content:

			vmi.Spec.TopologySpreadConstraints = topologySpreadConstraints
			vmiBytes, _ := json.Marshal(&vmi)

			ar := &admissionv1.AdmissionReview{
				Request: &admissionv1.AdmissionRequest{
					Resource: webhooks.VirtualMachineInstanceGroupVersionResource,
					Object: runtime.RawExtension{
						Raw: vmiBytes,
					},
				},
			}

			return vmiCreateAdmitter.Admit(ar)

This will not extend the current scope.

But I do not insist. If you prefer to do that outside of this PR I am okay with that.

[rmohr]

/approve

happy if @vasiliy-ul can conclude the review.

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rmohr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alaypatel07]

/hold

Trying out suggestions from @vasiliy-ul

[alaypatel07]

/hold cancel

[alaypatel07]

/refresh

[vasiliy-ul]

Looks good. Thanks 👍

[kubevirt-bot]

@alaypatel07: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubevirt-fossa	392ee0c	link	false	/test pull-kubevirt-fossa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[alaypatel07]

• [SLOW TEST] [13.016 seconds]
KubeVirt Operator On install strategy dump should generate latest install strategy and post as config map
pkg/virt-operator/kubevirt_test.go:2990
------------------------------
-- Test timed out at 2022-08-11 15:17:11 UTC --
================================================================================

Failure looks unrelated to the changes https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/8273/pull-kubevirt-unit-test/1557741671075024896

[rmohr]

/retest-required