fix guest memory setting #8367
fix guest memory setting #8367
Conversation
kubevirt-bot
added
release-note
|
/cc @rmohr @davidvossel |
vladikr
force-pushed
the
fix_guest_vmem
branch
from
15e82de
to
b2090c1
Compare
tests/vmi_configuration_test.go
Outdated
| Expect(domXml).To(ContainSubstring(expectedMemoryXMLStr)) | ||
|
|
||
| }, | ||
| Entry("provided by domain spec directly", pointer.Int(512), nil, nil), |
There was a problem hiding this comment.
This could be simpler by using options. WithGuestMemory, WithLimitMemory WithResourceMemory. You just need to use New rather than NewAlpine to not get the default.
tests/vmi_configuration_test.go
Outdated
| @@ -624,8 +681,10 @@ var _ = Describe("[sig-compute]Configurations", func() { | |||
| Context("[rfe_id:140][crit:medium][vendor:cnv-qe@redhat.com][level:component]with diverging memory limit from memory request and no guest memory", func() { | |||
| It("[test_id:3115]should show the memory limit inside the VMI", func() { | |||
| vmi := libvmi.NewCirros() | |||
| vmi.Spec.Domain.Resources.Limits = kubev1.ResourceList{ | |||
| kubev1.ResourceMemory: resource.MustParse("256Mi"), | |||
| vmi.Spec.Domain.Resources = v1.ResourceRequirements{ | |||
There was a problem hiding this comment.
This is overriding the memory, do we want it? Let's change the name if we do.
Signed-off-by: Vladik Romanovsky <vromanso@redhat.com>
vladikr
force-pushed
the
fix_guest_vmem
branch
from
b2090c1
to
db05592
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xpivarc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest |
|
@vladikr: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
It appears that we are incorrectly setting the guest memory to equal
resources.limits.memory.VMI specs that don't explicitly provide a value for
domain.memory.guestand provide different values for resources requests and limits will be converted to a domain definition where guest memory equals
resources.limits.memory.Special notes for your reviewer:
From my recollection, we used to have a vmi mutator webhook that set the correct value, but I don't see it right now.
Release note: