Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtiofs: Container approach #8375

Merged
merged 4 commits into from
Sep 28, 2022
Merged

Virtiofs: Container approach #8375

merged 4 commits into from
Sep 28, 2022

Conversation

xpivarc
Copy link
Member

@xpivarc xpivarc commented Aug 29, 2022

What this PR does / why we need it:
This work is based on #7570. It allows us to use virtiofs with Nonroot feature gate.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Virtiofs can be used with Nonroot feature gate

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Aug 29, 2022
@xpivarc
Copy link
Member Author

xpivarc commented Aug 29, 2022

/test all

@vladikr Here is my draft. The only major topic for me is if we want to monitor the process or launch the virtiofsd directly(I want to think about the shutdown process). Apart from that, I want to add tests with multiple filesystems but the code is ready to review.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2022
@vladikr
Copy link
Member

vladikr commented Sep 6, 2022

@vladikr Here is my draft. The only major topic for me is if we want to monitor the process or launch the virtiofsd directly(I want to think about the shutdown process). Apart from that, I want to add tests with multiple filesystems but the code is ready to review.

Yeah, great! I think this monitoring process is not needed. You're right. Initially, I added it so it could expose a socket that virt-handler would be able to find the virtiofs container in case we would need to change anything during the mount.
But it's just not necessary.

@xpivarc xpivarc marked this pull request as ready for review September 9, 2022 20:57
@kubevirt-bot kubevirt-bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 9, 2022
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2022
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2022
@xpivarc
Copy link
Member Author

xpivarc commented Sep 19, 2022

@vladikr PTAL

@xpivarc
Virtiofs: Option to generate container
5f58643 
Each filesystem will have own virtiofsd in
separate container to allow compute container
running session mode.

Signed-off-by: L. Pivarc <lpivarc@redhat.com>
@xpivarc
Virtiofs: Switch to container approach
d4e7026 
Signed-off-by: L. Pivarc <lpivarc@redhat.com>
@xpivarc
Virtiofs: Enable Nonroot
7d024c7 
Signed-off-by: L. Pivarc <lpivarc@redhat.com>
@xpivarc
Test: Multiple FS PVCs
afac638 
Signed-off-by: L. Pivarc <lpivarc@redhat.com>
@xpivarc
Copy link
Member Author

xpivarc commented Sep 19, 2022

Pushed test with multiple pvcs

@vladikr
Copy link
Member

vladikr commented Sep 26, 2022

Overall, looks great!
/approve
/retest

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vladikr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2022
@vladikr
Copy link
Member

vladikr commented Sep 26, 2022

@alicefr @acardace could you please take a look as well?

@jean-edouard
Copy link
Contributor

/cc

@acardace
Copy link
Member

@alicefr @acardace could you please take a look as well?

sure, will do.

acardace
acardace approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@acardace acardace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work, thanks @xpivarc!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2022
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Sep 27, 2022 •
edited

@xpivarc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-fossa da0fc85 link false /test pull-kubevirt-fossa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit e22b6e1 into kubevirt:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acardace acardace acardace approved these changes

@iholder101 iholder101 Awaiting requested review from iholder101

@kbidarkar kbidarkar Awaiting requested review from kbidarkar

@EdDev EdDev Awaiting requested review from EdDev

@jean-edouard jean-edouard Awaiting requested review from jean-edouard

Assignees

@acardace acardace

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xpivarc @kubevirt-bot @vladikr @jean-edouard @acardace @kubevirt-commenter-bot