Rename metrics to follow the naming convention

[machadovilaca]

Signed-off-by: João Vilaça jvilaca@redhat.com

What this PR does / why we need it:

kubevirt_vmi_memory_domain_total_bytes and kubevirt_vmi_filesystem_total_bytes were not following the metrics naming convention that we are following in the other metrics. This PR renames them.

kubevirt_vmi_memory_domain_total_bytes -> kubevirt_vmi_filesystem_capacity_bytes_total
kubevirt_vmi_filesystem_total_bytes -> kubevirt_vmi_memory_domain_bytes_total

Release note:

Rename metrics to follow the naming convention

[machadovilaca]

/retest

[machadovilaca]

/cc @enp0s3

[enp0s3]

/approve

NOTE: for the long-term, an automatic validation should take place for such occasions.

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [enp0s3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[machadovilaca]

/retest

[kubevirt-bot]

@machadovilaca: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubevirt-fossa	b8f590f	link	false	/test pull-kubevirt-fossa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[machadovilaca]

/cherry-pick release-0.53

[kubevirt-bot]

@machadovilaca: #8401 failed to apply on top of branch "release-0.53":

Applying: Rename metrics to follow naming convention
Using index info to reconstruct a base tree...
M	docs/metrics.md
M	pkg/monitoring/domainstats/prometheus/prometheus.go
M	pkg/monitoring/domainstats/prometheus/prometheus_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/monitoring/domainstats/prometheus/prometheus_test.go
CONFLICT (content): Merge conflict in pkg/monitoring/domainstats/prometheus/prometheus_test.go
Auto-merging pkg/monitoring/domainstats/prometheus/prometheus.go
CONFLICT (content): Merge conflict in pkg/monitoring/domainstats/prometheus/prometheus.go
Auto-merging docs/metrics.md
CONFLICT (content): Merge conflict in docs/metrics.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Rename metrics to follow naming convention
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.53

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.