[release-0.53] sriov: Fix network to PCI-Address mapping #8416
Conversation
|
Skipping CI for Draft Pull Request. |
kubevirt-bot
added
release-note-none
In order to use the latest network-status annotation api, that among else exposes pci-device information on sriov secondary nic, bumping multus-client vendor to v1.3.0 Signed-off-by: Ram Lavi <ralavi@redhat.com>
RamLavi
force-pushed
the
release-0.53_move_multus_methods
branch
from
72f53ac
to
bb49fb7
Compare
|
/test pull-kubevirt-unit-test |
|
@RamLavi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubevirt-unit-test |
|
@RamLavi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubevirt-unit-test-0.53 |
|
we expect this test to fail on lane This is because multus is not updated on the branch, hence we fall back to the old mapping. |
RamLavi
changed the title
RamLavi
changed the title
Signed-off-by: Ram Lavi <ralavi@redhat.com>
Signed-off-by: Ram Lavi <ralavi@redhat.com>
Signed-off-by: Ram Lavi <ralavi@redhat.com>
The new package is used to give consistent names to networks and their pod interfaces. The primary network is using a pod interface name (eth0) that is defined in this package and should be used by other packages for consistency. Signed-off-by: Ram Lavi <ralavi@redhat.com>
There is a need to consolidate the pod-interface name scheme of networks given in the VMI spec, so that they can be approached in consistent way in different times in the VMI's lifecycle. Introducing NameScheme that maps network names to their appropriate network/pod interface name. Signed-off-by: Ram Lavi <ralavi@redhat.com>
RamLavi
force-pushed
the
release-0.53_move_multus_methods
branch
from
28d6475
to
d1638ca
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
/approve |
kubevirt-bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlonaKaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
RamLavi
force-pushed
the
release-0.53_move_multus_methods
branch
from
d2e88f7
to
1825b84
Compare
The new test added in order to check network-status annotation based mapping of the networks to the appropriate PCI-Address - will consistently pass only if the annotation exists and holds the pci-data. In older versions of Multus the network-status annotation does not hold the PCI-Address data (on version >=3.7 [0]) [0] https://github.com/k8snetworkplumbingwg/multus-cni/releases/tag/v3.7 Signed-off-by: Ram Lavi <ralavi@redhat.com>
RamLavi
force-pushed
the
release-0.53_move_multus_methods
branch
from
1825b84
to
96dd7a8
Compare
|
fixed |
kubevirt-bot
removed
the
do-not-merge/hold
|
/retest |
|
/retest-required |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
@RamLavi: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
|
/retest-required |
|
/cherry-pick release-0.49 |
|
@phoracek: #8416 failed to apply on top of branch "release-0.49": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This is a manual cherry-pick of the following PRs:
diffs:
network/nameschemepackage to lint since it doesn't exist in this branchdiffs:
network/sriovpackage to lint since it doesn't exist in this branchEscapeJSONPointer()fromkubevirt.io/kubevirt/pkg/controllersince it didn't move yet.rendervolumes.gois not introduced yetfindIfaceByMAC()(source) needed for test.This cherry pick PR fixes #7444 on
release-0.53branchWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: