[release-0.57] [Bugfix]: HyperV Reenlightenment VMIs should be able to start when TSC Frequency is not exposed #8469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VMIs that use HyperV with Reenlightenment (and, implicitly, VMX, as it's being automatically added to such VMIs) cannot migrate without explicitly providing TSC frequency to QEMU (more info on that can be found here: kubevirt#7986). In Kubevirt we have a mechanism for exposing TSC frequency to the nodes using node-labeller. However, sometimes (e.g. on some virtual nodes) the frequency is not exposed. Therefore, VMIs with Reenlightenment shouldn't be migratable - but they should be able to run. Signed-off-by: Itamar Holder <iholder@redhat.com>
Before recent changes, TSC Frequency was added to the domain XML only if "invtsc" feature was defined as enabled at the VMI's CPU. Now this is no longer the case, as hyperV Reenligtenment VMs need to have TSC frequency but don't have to enable any specific CPU feature. Signed-off-by: Itamar Holder <iholder@redhat.com>
Signed-off-by: Itamar Holder <iholder@redhat.com>
Now the test is skipped if TSC frequency is not exposed on the cluster. Signed-off-by: Itamar Holder <iholder@redhat.com>
When TSC Frequency is not exposed. Signed-off-by: Itamar Holder <iholder@redhat.com>
Signed-off-by: Itamar Holder <iholder@redhat.com>
kubevirt-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enp0s3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
Seems like we have no presubmit jobs to release 0.57 yet. |
This was referenced Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8359
/assign Barakmor1