Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud-init: Skip networkData lookup if not needed #8536

Merged
merged 1 commit into from Sep 29, 2022
Merged

cloud-init: Skip networkData lookup if not needed #8536

merged 1 commit into from Sep 29, 2022

Conversation

qinqon
Copy link
Contributor

@qinqon qinqon commented Sep 28, 2022

What this PR does / why we need it:
When a ConfigDrive cloud-init is configured the networkData from the mounted secret has to be only checked if NetworkDataSecretRef is set.

Release note:

Don't show a failure if ConfigDrive cloud init has UserDataSecretRef and not NetworkDataSecretRef

@qinqon
cloud-init: Skip networkData lookup if not needed
6a34852 
When a ConfigDrive cloud-init is configured the networkData from the
mounted secret has to be only checked if NetworkDataSecretRef is set.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 28, 2022
@qinqon
Copy link
Contributor Author

qinqon commented Sep 28, 2022

/cc @davidvossel

At the end this is just cosmetics I think.

davidvossel
davidvossel reviewed Sep 28, 2022
View reviewed changes
Copy link
Member

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 4de7e97 into kubevirt:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel davidvossel left review comments

@alicefr alicefr Awaiting requested review from alicefr

@enp0s3 enp0s3 Awaiting requested review from enp0s3

Assignees

@davidvossel davidvossel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qinqon @kubevirt-bot @kubevirt-commenter-bot @davidvossel