-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump memory requests according to values seen in testing #8613
Conversation
Signed-off-by: Jed Lejosne <jed@redhat.com>
/cherry-pick release-0.53 |
@jean-edouard: once the present PR merges, I will cherry-pick it on top of release-0.53 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
One source for big memory consumption with many informers could be |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enp0s3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest-required |
2 similar comments
/retest-required |
/retest-required |
@jean-edouard: new pull request created: #8687 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.49 |
@jean-edouard: #8613 failed to apply on top of branch "release-0.49":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.58 |
@acardace: new pull request created: #8709 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR bumps up the memory requests for various components (namely virt-operator, virt-api and virt-handler).
I took the highest values seen in recent testing and rounded them up. These are the values:
virt-operator: 380MB
virt-api: 300MB
virt-controller: 250MB
virt-handler: 270MB
Having values that are too low not only triggers many
KubeVirtComponentExceedsRequestedMemory
alerts, but also risks getting killed on busy nodes.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
These values are high, but they just represent our current consumption.
As a separate effort, we need to investigate the high memory needs of our components, and hopefully find ways to lower them.
virt-operator is especially concerning.
Release note: