Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump memory requests according to values seen in testing #8613

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

jean-edouard
Copy link
Contributor

What this PR does / why we need it:
This PR bumps up the memory requests for various components (namely virt-operator, virt-api and virt-handler).
I took the highest values seen in recent testing and rounded them up. These are the values:
virt-operator: 380MB
virt-api: 300MB
virt-controller: 250MB
virt-handler: 270MB

Having values that are too low not only triggers many KubeVirtComponentExceedsRequestedMemory alerts, but also risks getting killed on busy nodes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
These values are high, but they just represent our current consumption.
As a separate effort, we need to investigate the high memory needs of our components, and hopefully find ways to lower them.
virt-operator is especially concerning.

Release note:

NONE

Signed-off-by: Jed Lejosne <jed@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 17, 2022
@jean-edouard
Copy link
Contributor Author

/cherry-pick release-0.53

@kubevirt-bot
Copy link
Contributor

@jean-edouard: once the present PR merges, I will cherry-pick it on top of release-0.53 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.53

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rmohr
Copy link
Member

rmohr commented Oct 17, 2022

One source for big memory consumption with many informers could be managedFields: kubernetes/kubernetes#107507

@enp0s3
Copy link
Contributor

enp0s3 commented Oct 18, 2022

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2022
@Barakmor1
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2022
@brianmcarey
Copy link
Member

/retest-required

2 similar comments
@dhiller
Copy link
Contributor

dhiller commented Oct 26, 2022

/retest-required

@acardace
Copy link
Member

/retest-required

@kubevirt-bot
Copy link
Contributor

@jean-edouard: new pull request created: #8687

In response to this:

/cherry-pick release-0.53

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jean-edouard
Copy link
Contributor Author

/cherry-pick release-0.49

@kubevirt-bot
Copy link
Contributor

@jean-edouard: #8613 failed to apply on top of branch "release-0.49":

Applying: Bump memory requests according to value seen in testing
Using index info to reconstruct a base tree...
M	manifests/generated/operator-csv.yaml.in
M	pkg/virt-operator/resource/generate/components/daemonsets.go
M	pkg/virt-operator/resource/generate/components/deployments.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/virt-operator/resource/generate/components/deployments.go
CONFLICT (content): Merge conflict in pkg/virt-operator/resource/generate/components/deployments.go
Auto-merging pkg/virt-operator/resource/generate/components/daemonsets.go
Auto-merging manifests/generated/operator-csv.yaml.in
CONFLICT (content): Merge conflict in manifests/generated/operator-csv.yaml.in
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bump memory requests according to value seen in testing
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.49

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@acardace
Copy link
Member

acardace commented Nov 2, 2022

/cherry-pick release-0.58

@kubevirt-bot
Copy link
Contributor

@acardace: new pull request created: #8709

In response to this:

/cherry-pick release-0.58

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants