Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make exporter pod PSA ready #8652

Merged
merged 1 commit into from Oct 27, 2022
Merged

Conversation

akalenyu
Copy link
Contributor

@akalenyu akalenyu commented Oct 23, 2022

Signed-off-by: Alex Kalenyuk akalenyu@redhat.com

What this PR does / why we need it:
AFAIK there is no reason to not make this pod fully PSA ready, most things were already there.

E1023 15:51:16.640185       1 util.go:72] pods "virt-export-vme-test-whttslbd8wvd" is forbidden: violates PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "vme-test-whttslbd8wvd" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "vme-test-whttslbd8wvd" must set securityContext.capabilities.drop=["ALL"]), seccompProfile (pod or container "vme-test-whttslbd8wvd" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://bugzilla.redhat.com/show_bug.cgi?id=2137123

Special notes for your reviewer:

Release note:

BugFix: Exporter pod does not comply with restricted PSA

AFAIK there is no reason to not make this pod fully PSA ready,
most things were already there.

```bash
E1023 15:51:16.640185       1 util.go:72] pods "virt-export-vme-test-whttslbd8wvd" is forbidden: violates PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "vme-test-whttslbd8wvd" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "vme-test-whttslbd8wvd" must set securityContext.capabilities.drop=["ALL"]), seccompProfile (pod or container "vme-test-whttslbd8wvd" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
```

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Oct 23, 2022
@akalenyu
Copy link
Contributor Author

/cc @awels @mhenriks

@mhenriks
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@akalenyu
Copy link
Contributor Author

/retest

6 similar comments
@akalenyu
Copy link
Contributor Author

/retest

@akalenyu
Copy link
Contributor Author

/retest

@akalenyu
Copy link
Contributor Author

/retest

@akalenyu
Copy link
Contributor Author

/retest

@akalenyu
Copy link
Contributor Author

/retest

@akalenyu
Copy link
Contributor Author

/retest

@akalenyu
Copy link
Contributor Author

/test pull-kubevirt-e2e-k8s-1.22-operator

@akalenyu
Copy link
Contributor Author

/retest

2 similar comments
@akalenyu
Copy link
Contributor Author

/retest

@akalenyu
Copy link
Contributor Author

/retest

@kubevirt-bot kubevirt-bot merged commit 83d627f into kubevirt:main Oct 27, 2022
@akalenyu
Copy link
Contributor Author

/cherrypick release-0.58

@kubevirt-bot
Copy link
Contributor

@akalenyu: new pull request created: #8685

In response to this:

/cherrypick release-0.58

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants