Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect KubevirtVmHighMemoryUsage description #9073

Merged
merged 1 commit into from Jun 14, 2023
Merged

Fix incorrect KubevirtVmHighMemoryUsage description #9073

merged 1 commit into from Jun 14, 2023

Conversation

machadovilaca
Copy link
Member

Signed-off-by: João Vilaça jvilaca@redhat.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Fix incorrect KubevirtVmHighMemoryUsage description

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Jan 19, 2023
@machadovilaca machadovilaca mentioned this pull request Jan 19, 2023
Merged
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2023
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2023
@machadovilaca machadovilaca force-pushed the update-KubevirtVmHighMemoryUsage-description branch from 4366e52 to fe854c3 Compare June 9, 2023 16:46
@kubevirt-bot kubevirt-bot added size/S and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS labels Jun 9, 2023
@machadovilaca
Fix incorrect KubevirtVmHighMemoryUsage description
4bdeabe 
Signed-off-by: João Vilaça <jvilaca@redhat.com>
@machadovilaca machadovilaca force-pushed the update-KubevirtVmHighMemoryUsage-description branch from fe854c3 to 4bdeabe Compare June 9, 2023 16:46
@machadovilaca
Copy link
Member Author

@lyarwood updated

enp0s3
enp0s3 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@brianmcarey
Copy link
Member

/retest

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Jun 13, 2023 •
edited

@machadovilaca: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-fossa 4366e52 link false /test pull-kubevirt-fossa
pull-kubevirt-e2e-k8s-1.24-sig-compute 4366e52 link true /test pull-kubevirt-e2e-k8s-1.24-sig-compute

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit fa854d0 into kubevirt:main Jun 14, 2023
35 checks passed
This was referenced Jun 27, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyarwood lyarwood lyarwood left review comments

@enp0s3 enp0s3 enp0s3 approved these changes

@rthallisey rthallisey Awaiting requested review from rthallisey

Assignees

@enp0s3 enp0s3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@machadovilaca @kubevirt-bot @brianmcarey @kubevirt-commenter-bot @lyarwood @enp0s3