Revert "Add checks of dedicatedCPUPlacement to validation webhook"

[lyarwood]

/area instancetype
/cc @opokornyy
/cc @davidvossel

What this PR does / why we need it:

This reverts commit 48a2ade.

Thanks to e7898af [1][2] we now apply defaults to a copy of the VirtualMachineInstanceSpec before running the associated validations in the VirtualMachine validation webhook. This actually resolves the original issue with enabling dedicatedCPUPlacement from instance types [3] as it ensures any guest visible memory is expressed as resources requests before we attempt to validate.

As such we can drop the blocking validations from the instance type webhooks and allow dedicatedCPUPlacement to be set once again.

[1] #9103
[2] #9102
[3] #8867

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

With this commit reverted in a test environment the following examples work once again:

$ ./cluster-up/kubectl.sh apply -f - << EOF
apiVersion: instancetype.kubevirt.io/v1alpha2
kind: VirtualMachineClusterInstancetype
metadata:
 name: dedicatedcpuplacement
spec:
 cpu:
  dedicatedCPUPlacement: true
  guest: 1
 memory: 
  guest: 128Mi
EOF
selecting docker as container runtime
virtualmachineclusterinstancetype.instancetype.kubevirt.io/dedicatedcpuplacement created
$ ./cluster-up/kubectl.sh apply -f - << EOF
apiVersion: kubevirt.io/v1
kind: VirtualMachine
metadata:
  labels:
    kubevirt.io/vm: vm-cirros
  name: vm-cirros
spec:
  instancetype:
    name: dedicatedcpuplacement
  running: true
  template:
    spec:
      domain:
        devices: {}
      terminationGracePeriodSeconds: 0
      volumes:
      - containerDisk:
          image: registry:5000/kubevirt/cirros-container-disk-demo:devel
        name: containerdisk
EOF
selecting docker as container runtime
virtualmachine.kubevirt.io/vm-cirros configured

Release note:

The `dedicatedCPUPlacement` attribute is once again supported within the `VirtualMachineInstancetype` and `VirtualMachineClusterInstancetype` CRDs after a recent bugfix improved `VirtualMachine` validations, ensuring defaults are applied before any attempt to validate.

[0xFelix]

/lgtm

[0xFelix]

/retest

[lyarwood]

/cherry-pick release-0.59

[kubevirt-bot]

@lyarwood: once the present PR merges, I will cherry-pick it on top of release-0.59 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.59

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[davidvossel]

in general this makes sense. Can we get some test coverage of dedicated cpu placement with instance types now? That feature is complex enough that I'd like to ensure it is both working and continues to work as expected with instance types moving forward

[lyarwood]

in general this makes sense. Can we get some test coverage of dedicated cpu placement with instance types now? That feature is complex enough that I'd like to ensure it is both working and continues to work as expected with instance types moving forward

ACK added in the commit below, thanks @davidvossel !

fa66a7a

[lyarwood]

/retest-required

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/9169/pull-kubevirt-e2e-k8s-1.25-sig-compute/1623751431183929344

Tests Suite: [crit:medium][vendor:cnv-qe@redhat.com][level:component][sig-compute] Instancetype and Preferences instance type with dedicatedCPUPlacement enabled should be accepted and result in running VirtualMachineInstance | 26s
-- | --

Looks like that is passing in the compute lanes FWIW.

[kubevirt-bot]

@lyarwood: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubevirt-fossa	fa66a7a	link	false	/test pull-kubevirt-fossa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[0xFelix]

/lgtm

[lyarwood]

/retest-required

[davidvossel]

/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [davidvossel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubevirt-commenter-bot]

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[kubevirt-commenter-bot]

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[kubevirt-bot]

@lyarwood: new pull request created: #9234

In response to this:

/cherry-pick release-0.59

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.