Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virt-handler: Add live-migration bridge pod net annotation #9193

Merged
merged 1 commit into from
Feb 21, 2023
Merged

virt-handler: Add live-migration bridge pod net annotation #9193

merged 1 commit into from
Feb 21, 2023

Conversation

qinqon
Copy link
Contributor

@qinqon qinqon commented Feb 8, 2023 •
edited

What this PR does / why we need it:
At some scenarios like hypershift kubevirt provider the CNI will support
doing live-migration when the VM net interface is bridged to the pod
network. This change add a annotation to allow live migration is
configured so on those scenarios.

Release note:

Add annotation for live migration and bridged pod interface

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Feb 8, 2023
@qinqon qinqon force-pushed the primary-interface-bridge-binding-live-migration branch from 5867287 to a8a6df7 Compare February 8, 2023 09:15
@qinqon qinqon mentioned this pull request Feb 8, 2023
Closed
22 tasks
@davidvossel
Copy link
Member

/cc @davidvossel

davidvossel
davidvossel reviewed Feb 9, 2023
View reviewed changes
pkg/virt-handler/vm.go Outdated Show resolved Hide resolved
@qinqon qinqon force-pushed the primary-interface-bridge-binding-live-migration branch from a8a6df7 to ef95af8 Compare February 20, 2023 16:30
@kubevirt-bot kubevirt-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/network labels Feb 20, 2023
@qinqon qinqon changed the title feature-gate: Add live-migration bridge pod net virt-handler: Add live-migration bridge pod net annotation Feb 20, 2023
@qinqon
virt-handler: Add live-migration bridge pod net annotation
f09a088 
At some scenarios like hypershift kubevirt provider the CNI will support
doing live-migration when the VM net interface is bridged to the pod
network. This change add a annotation to allow live migration is
configured so on those scenarios.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon qinqon force-pushed the primary-interface-bridge-binding-live-migration branch from ef95af8 to f09a088 Compare February 20, 2023 16:32
@qinqon qinqon requested review from davidvossel and removed request for vladikr and vasiliy-ul February 20, 2023 16:32
davidvossel
davidvossel reviewed Feb 20, 2023
View reviewed changes
Copy link
Member

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

yep makes sense to me.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@qinqon
Copy link
Contributor Author

qinqon commented Feb 21, 2023

/retest

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Feb 21, 2023 •
edited

@qinqon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-fossa f09a088 link false /test pull-kubevirt-fossa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot merged commit 76facc1 into kubevirt:main Feb 21, 2023
@fabiand
Copy link
Member

fabiand commented May 11, 2023

@kvaps fyi - with OVNK this annotation can be used.

@kvaps
Copy link
Member

kvaps commented May 12, 2023

@fabiand oh, thanks for information! ❤️

@kvaps kvaps mentioned this pull request May 12, 2023
Open
89 tasks
@ikandars
Copy link

ikandars commented Jul 15, 2023 •
edited

I've been waiting this feature.

Just tested this annotation and I can confirmed it works with Kube-OVN CNI 🎉 🎉

@xpivarc xpivarc mentioned this pull request Aug 14, 2023
Closed
@wozniakjan wozniakjan mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel davidvossel left review comments

Assignees

@davidvossel davidvossel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@qinqon @davidvossel @kubevirt-bot @kubevirt-commenter-bot @fabiand @kvaps @ikandars