Fix pod expectation on migration #9478
Conversation
We need to reset the expectation on PSA error to be able to retry the migration. Signed-off-by: L. Pivarc <lpivarc@redhat.com>
kubevirt-bot
added
release-note
| return psaErr | ||
| } else if err != nil { | ||
| c.recorder.Eventf(vmi, k8sv1.EventTypeWarning, FailedCreatePodReason, "Error creating pod: %v", err) | ||
| if err != nil { |
There was a problem hiding this comment.
I would even move the expectation reset directly under the err check.
There was a problem hiding this comment.
👍 I will edit this if a chance comes up.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rmohr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
@xpivarc: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
|
/cherry-pick release-0.59 |
|
@xpivarc: new pull request created: #9507 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
We need to reset the expectation on PSA error to be able to retry the migration.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: