Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stamp for virt-operator #9590

Merged
merged 1 commit into from Oct 10, 2023
Merged

fix stamp for virt-operator #9590

merged 1 commit into from Oct 10, 2023

Conversation

xuzhenglun
Copy link
Contributor

What this PR does / why we need it:
virt-operator would write current version to status.operatorVersion of KubeVirt CR. but in current build rule, stamp is missing.

image

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

fix embed version info of virt-operator

@xuzhenglun
fix stamp for virt-operator
642cb4d 
Signed-off-by: Reficul <xuzhenglun@gmail.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS labels Apr 7, 2023
@kubevirt-bot
Copy link
Contributor

Hi @xuzhenglun. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the kind/build-change Categorizes PRs as related to changing build files of virt-* components label Apr 7, 2023
@xuzhenglun
Copy link
Contributor Author

@xpivarc

hi, would you like to help take a look at this PR if possible?

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 11, 2023
@xuzhenglun
Copy link
Contributor Author

/remove-lifecycle stale

@lyarwood
Sorry for the abruptness, but would you mind reviewing my code? I would really appreciate your feedback. If you're unavailable or too busy, please feel free to suggest someone else who might be able to help.

Thanks.

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 11, 2023
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 9, 2023
@maiqueb
Copy link
Contributor

maiqueb commented Oct 10, 2023

I can confirm this issue is real.
Deploying from latest main I see the operator version as reported in this PR.

/remove-lifecycle stale

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 10, 2023
xpivarc
xpivarc approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
maiqueb
maiqueb approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that deploying from this PR the operatorVersion reported in the KubeVirt CR is correct:

kubectl get kubevirt kubevirt -nkubevirt -ojsonpath="{ @.status.operatorVersion }"    
v0.60.0-alpha.0.97+642cb4ddec1b14

@maiqueb
Copy link
Contributor

maiqueb commented Oct 10, 2023

/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2023
@xuzhenglun
Copy link
Contributor Author

/retest

@kubevirt-bot kubevirt-bot merged commit a69ec67 into kubevirt:main Oct 10, 2023
36 of 37 checks passed
@maiqueb
Copy link
Contributor

maiqueb commented Oct 11, 2023

/cherrypick release-1.0

@kubevirt-bot
Copy link
Contributor

@maiqueb: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client

In response to this:

/cherrypick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brianmcarey
Copy link
Member

/cherrypick release-1.0

@kubevirt-bot
Copy link
Contributor

@brianmcarey: new pull request created: #10554

In response to this:

/cherrypick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiqueb maiqueb maiqueb approved these changes

@xpivarc xpivarc xpivarc approved these changes

@marceloamaral marceloamaral Awaiting requested review from marceloamaral

@stu-gott stu-gott Awaiting requested review from stu-gott

Assignees

@maiqueb maiqueb

@xpivarc xpivarc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/build-change Categorizes PRs as related to changing build files of virt-* components lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xuzhenglun @kubevirt-bot @maiqueb @brianmcarey @xpivarc