Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[node-labeller] Labeling of nodes with ksm enabled #9691

Merged
merged 1 commit into from
May 15, 2023
Merged

[node-labeller] Labeling of nodes with ksm enabled #9691

merged 1 commit into from
May 15, 2023

Conversation

fossedihelm
Copy link
Contributor

What this PR does / why we need it:
If KSM is enabled (not only available) on a node,
then handler will add kubevirt.io/ksm-enabled label to the node.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

ksm enabled nodes will have `kubevirt.io/ksm-enabled` label

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M labels May 3, 2023
@kubevirt-bot kubevirt-bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label May 3, 2023
@fossedihelm
Labeling of nodes with ksm enabled
a540e0c 
If KSM is enabled (not only available) on a node,
then handler will add `kubevirt.io/ksm-enabled` label to the node.

Signed-off-by: fossedihelm <ffossemo@redhat.com>
@fossedihelm fossedihelm force-pushed the label_node_with_ksm_enabled branch from 5774ecc to a540e0c Compare May 3, 2023 16:49
@fossedihelm
Copy link
Contributor Author

/retest

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented May 4, 2023 •
edited

@fossedihelm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-fossa a540e0c link false /test pull-kubevirt-fossa
pull-kubevirt-e2e-arm64 a540e0c link false /test pull-kubevirt-e2e-arm64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fossedihelm
Copy link
Contributor Author

/cc @xpivarc @Barakmor1 @dhiller

Barakmor1
Barakmor1 reviewed May 4, 2023
View reviewed changes
Copy link
Member

@Barakmor1 Barakmor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey ,
Can you please explain why do we need to expose this label?
who would benefit from such label and will we use it in the future?
and just a small nit.

pkg/virt-handler/node-labeller/model.go Show resolved Hide resolved
@fossedihelm
Copy link
Contributor Author

Hey , Can you please explain why do we need to expose this label? who would benefit from such label and will we use it in the future?

The benefit is that you can use label selectors in your workloads and choose whether or not to schedule them in nodes with ksm enabled, and thus to refine the load more precisely.
Furthermore, there should be some other improvements in future (i.e. schedule the high performarce vmis only in ksm disabled nodes)

@Barakmor1
Copy link
Member

Barakmor1 commented May 4, 2023 •
edited

/lgtm
I'm convinced.
Thanks for the explanation
But i think that you should include it in the commit massage

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2023
xpivarc
xpivarc reviewed May 15, 2023
View reviewed changes
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit e969a02 into kubevirt:main May 15, 2023
35 of 37 checks passed
@fossedihelm fossedihelm mentioned this pull request May 19, 2023
Merged
@fossedihelm fossedihelm deleted the label_node_with_ksm_enabled branch June 20, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpivarc xpivarc xpivarc left review comments

@Barakmor1 Barakmor1 Barakmor1 left review comments

@AlonaKaplan AlonaKaplan Awaiting requested review from AlonaKaplan

@mhenriks mhenriks Awaiting requested review from mhenriks

@dhiller dhiller Awaiting requested review from dhiller

Assignees

@Barakmor1 Barakmor1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fossedihelm @kubevirt-bot @Barakmor1 @kubevirt-commenter-bot @xpivarc