Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add upgrade note regarding v1 storage version migration #9747

Conversation

lyarwood
Copy link
Member

@lyarwood lyarwood commented May 16, 2023

What this PR does / why we need it:

The following PR recently merged moving the storage version of all core objects to v1:

#9628

To accommodate the eventual removal of the original v1alpha3 version this change adds a note to the updates document recommending the use of the kube-storage-version-migrator tool to automate the upgrade of all stored core objects to v1 ahead of the removal of v1alpha3.

An older note suggesting new CRD versions are not allowed is also removed as this is no longer the case.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

action required - With the `v1.0.0` release of KubeVirt the storage version of all core `kubevirt.io` APIs will be moving to version `v1`. To accommodate the eventual removal of the `v1alpha3` version with KubeVirt >=`v1.2.0` it is recommended that operators deploy the [`kube-storage-version-migrator`](https://github.com/kubernetes-sigs/kube-storage-version-migrator) tool within their environment. This will ensure any existing `v1alpha3` stored objects are migrated to `v1` well in advance of the removal of the underlying `v1alpha3` version.

@kubevirt-bot kubevirt-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels May 16, 2023
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
The following PR recently merged moving the storage version of all core
objects to `v1`:

kubevirt#9628

To accommodate the eventual removal of the original `v1alpha3` version
this change adds a note to the updates document recommending the use of
the kube-storage-version-migrator tool to automate the upgrade of all
stored core objects to v1 ahead of the removal of v1alpha3.

An older note suggesting new CRD versions are not allowed is also
removed as this is no longer the case.

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood lyarwood force-pushed the kube-storage-version-migrator-upgrade-recommendation branch from 4fcb13c to b82938e Compare May 17, 2023 09:31
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit fd441ee into kubevirt:main May 23, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants