Add LiveMigrateIfPossible eviction strategy #9798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
kubevirt-bot
added
the
kind/api-change
|
/cc @acardace FYI |
kubevirt-bot
added
the
do-not-merge/work-in-progress
|
/test all |
rmohr
force-pushed
the
LiveMigrateIfPossible
branch
from
f189cde
to
83bad9f
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
/cc @davidvossel since you worked lately on an External eviction strategy. |
kubevirt-bot
added
the
needs-rebase
This strategy will only protect a VM with a PDB if the final determination if a VM is migratable is true. Further the eviction webhook will allow this VM to be evicted instead of migrated in case that the VM is not migratable. Signed-off-by: Roman Mohr <rmohr@google.com>
Signed-off-by: Roman Mohr <rmohr@google.com>
Signed-off-by: Roman Mohr <rmohr@google.com>
rmohr
force-pushed
the
LiveMigrateIfPossible
branch
from
83bad9f
to
2463177
Compare
kubevirt-bot
removed
the
needs-rebase
|
/lgtm |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xpivarc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a
LiveMigrateIfPossibleeviction strategy to the KubeVirt CR and VMIs. This strategy makes it easier to express an admin intent on the KubeVirt CR, that in general live-migrations are preferred, but if users do not explicitly request on VMs that they require a live-migration, non-migratable VMs would still just be stopped during evictions.This solves the issue, that right now we would create for non-migratable VMIs a PodDisruptionBudget if the cluster-wide eviction strategy is
LiveMigrate, leading to to the following two situations:Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #8555
Special notes for your reviewer:
Release note: