Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary marketplace tool #9811

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Remove unnecessary marketplace tool #9811

merged 1 commit into from
Jun 10, 2023

Conversation

machadovilaca
Copy link
Member

What this PR does / why we need it:

This tool is unnecessary, it is reading an empty repository https://quay.io/cnr and is forcing KubeVirt to use a very old version of controller runtime to work: sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.6.2

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Remove unnecessary marketplace tool

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels May 27, 2023
@machadovilaca machadovilaca force-pushed the remove-unecessary-marketplace-tool branch 3 times, most recently from e7e8e25 to 7eb9061 Compare May 29, 2023 14:18
@machadovilaca
Remove unnecessary marketplace tool
c271f47 
Signed-off-by: João Vilaça <jvilaca@redhat.com>
@machadovilaca machadovilaca force-pushed the remove-unecessary-marketplace-tool branch from 7eb9061 to c271f47 Compare May 29, 2023 15:10
@xpivarc
Copy link
Member

xpivarc commented May 30, 2023

@tiraboschi Do you recall why we had this?

@tiraboschi
Copy link
Member

@tiraboschi Do you recall why we had this?

I think it's only a leftover from ancient times before having HCO.

xpivarc
xpivarc reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023
@sradco
Copy link
Contributor

sradco commented Jun 6, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
@machadovilaca
Copy link
Member Author

/retest pull-kubevirt-e2e-kind-1.27-sriov

@kubevirt-bot
Copy link
Contributor

@machadovilaca: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-kubevirt-apidocs
  • /test pull-kubevirt-build
  • /test pull-kubevirt-build-arm64
  • /test pull-kubevirt-check-unassigned-tests
  • /test pull-kubevirt-client-python
  • /test pull-kubevirt-e2e-k8s-1.25-ipv6-sig-network
  • /test pull-kubevirt-e2e-k8s-1.25-sig-compute
  • /test pull-kubevirt-e2e-k8s-1.25-sig-compute-cgroupsv2
  • /test pull-kubevirt-e2e-k8s-1.25-sig-compute-migrations
  • /test pull-kubevirt-e2e-k8s-1.25-sig-network
  • /test pull-kubevirt-e2e-k8s-1.25-sig-operator
  • /test pull-kubevirt-e2e-k8s-1.25-sig-performance
  • /test pull-kubevirt-e2e-k8s-1.25-sig-storage
  • /test pull-kubevirt-e2e-k8s-1.25-sig-storage-cgroupsv2
  • /test pull-kubevirt-e2e-k8s-1.26-sig-compute
  • /test pull-kubevirt-e2e-k8s-1.26-sig-monitoring
  • /test pull-kubevirt-e2e-k8s-1.26-sig-network
  • /test pull-kubevirt-e2e-k8s-1.26-sig-operator
  • /test pull-kubevirt-e2e-k8s-1.26-sig-storage
  • /test pull-kubevirt-e2e-k8s-1.27-sig-compute
  • /test pull-kubevirt-e2e-k8s-1.27-sig-network
  • /test pull-kubevirt-e2e-k8s-1.27-sig-operator
  • /test pull-kubevirt-e2e-k8s-1.27-sig-storage
  • /test pull-kubevirt-e2e-kind-1.25-vgpu
  • /test pull-kubevirt-e2e-kind-1.27-sriov
  • /test pull-kubevirt-e2e-windows2016
  • /test pull-kubevirt-generate
  • /test pull-kubevirt-manifests
  • /test pull-kubevirt-prom-rules-verify
  • /test pull-kubevirt-unit-test
  • /test pull-kubevirt-verify-go-mod
  • /test pull-kubevirtci-bump-kubevirt

The following commands are available to trigger optional jobs:

  • /test build-kubevirt-builder
  • /test pull-kubevirt-check-tests-for-flakes
  • /test pull-kubevirt-code-lint
  • /test pull-kubevirt-e2e-arm64
  • /test pull-kubevirt-e2e-k8s-1.25-fips-sig-compute
  • /test pull-kubevirt-e2e-k8s-1.26-ipv6-sig-network
  • /test pull-kubevirt-e2e-k8s-1.26-sev
  • /test pull-kubevirt-e2e-k8s-1.26-sig-network-multus-v4
  • /test pull-kubevirt-e2e-k8s-1.26-single-node
  • /test pull-kubevirt-e2e-k8s-1.26-swap-enabled
  • /test pull-kubevirt-fossa
  • /test pull-kubevirt-gosec
  • /test pull-kubevirt-goveralls
  • /test pull-kubevirt-unit-test-arm64
  • /test pull-kubevirt-verify-rpms

Use /test all to run the following jobs that were automatically triggered:

  • pull-kubevirt-apidocs
  • pull-kubevirt-build
  • pull-kubevirt-build-arm64
  • pull-kubevirt-check-tests-for-flakes
  • pull-kubevirt-check-unassigned-tests
  • pull-kubevirt-client-python
  • pull-kubevirt-code-lint
  • pull-kubevirt-e2e-arm64
  • pull-kubevirt-e2e-k8s-1.25-ipv6-sig-network
  • pull-kubevirt-e2e-k8s-1.25-sig-compute
  • pull-kubevirt-e2e-k8s-1.25-sig-compute-migrations
  • pull-kubevirt-e2e-k8s-1.25-sig-network
  • pull-kubevirt-e2e-k8s-1.25-sig-operator
  • pull-kubevirt-e2e-k8s-1.25-sig-storage
  • pull-kubevirt-e2e-k8s-1.26-sig-compute
  • pull-kubevirt-e2e-k8s-1.26-sig-network
  • pull-kubevirt-e2e-k8s-1.26-sig-operator
  • pull-kubevirt-e2e-k8s-1.26-sig-storage
  • pull-kubevirt-e2e-k8s-1.27-sig-compute
  • pull-kubevirt-e2e-k8s-1.27-sig-network
  • pull-kubevirt-e2e-k8s-1.27-sig-operator
  • pull-kubevirt-e2e-k8s-1.27-sig-storage
  • pull-kubevirt-e2e-kind-1.25-vgpu
  • pull-kubevirt-e2e-kind-1.27-sriov
  • pull-kubevirt-e2e-windows2016
  • pull-kubevirt-fossa
  • pull-kubevirt-generate
  • pull-kubevirt-goveralls
  • pull-kubevirt-manifests
  • pull-kubevirt-prom-rules-verify
  • pull-kubevirt-unit-test
  • pull-kubevirt-unit-test-arm64
  • pull-kubevirt-verify-go-mod

In response to this:

/retest pull-kubevirt-e2e-kind-1.27-sriov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@machadovilaca
Copy link
Member Author

/test pull-kubevirt-e2e-kind-1.27-sriov

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 5a7c878 into kubevirt:main Jun 10, 2023
35 checks passed
@kubevirt-bot kubevirt-bot mentioned this pull request Jul 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpivarc xpivarc xpivarc left review comments

@EdDev EdDev Awaiting requested review from EdDev

Assignees

@sradco sradco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@machadovilaca @xpivarc @tiraboschi @kubevirt-bot @sradco @kubevirt-commenter-bot