Increase probability of flake check to reveal flakes #9840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
According to https://dl.acm.org/doi/abs/10.1145/3476105 * almost all flaky tests were independent of the execution platform, so environmental issues should be considered with higher priority * devs may be unaware of many flakes due to order-dependent tests * simple techniques of reversing or shuffling the test order may be more efficient and effective than more sophisticated approaches * “One study found that 88% of flaky tests were found to consecutively fail up to a maximum of five times before passing, though another reported finding new flaky tests even after 10,000 test suite runs.” Therefore we by default * use only latest kubevirtci provider, * run all changed tests five times and * randomize the test order each time Signed-off-by: Daniel Hiller <dhiller@redhat.com>
kubevirt-bot
added
release-note
dhiller
changed the title
|
/cc @brianmcarey |
fossedihelm
reviewed
Jul 4, 2023
| @@ -66,7 +66,7 @@ function functest() { | |||
| KUBEVIRT_FUNC_TEST_SUITE_ARGS="-skip-dual-stack-test ${KUBEVIRT_FUNC_TEST_SUITE_ARGS}" | |||
| fi | |||
|
|
|||
| _out/tests/ginkgo -timeout=3h -r -slow-spec-threshold=60s "$@" _out/tests/tests.test -- -kubeconfig=${kubeconfig} -container-tag=${docker_tag} -container-tag-alt=${docker_tag_alt} -container-prefix=${functest_docker_prefix} -image-prefix-alt=${image_prefix_alt} -oc-path=${oc} -kubectl-path=${kubectl} -gocli-path=${gocli} -installed-namespace=${namespace} -previous-release-tag=${PREVIOUS_RELEASE_TAG} -previous-release-registry=${previous_release_registry} -deploy-testing-infra=${deploy_testing_infra} -config=${kubevirt_test_config} --artifacts=${ARTIFACTS} --operator-manifest-path=${OPERATOR_MANIFEST_PATH} --testing-manifest-path=${TESTING_MANIFEST_PATH} ${KUBEVIRT_FUNC_TEST_SUITE_ARGS} -virtctl-path=${virtctl_path} -example-guest-agent-path=${example_guest_agent_path} | |||
| _out/tests/ginkgo -timeout=3h -r "$@" _out/tests/tests.test -- -kubeconfig=${kubeconfig} -container-tag=${docker_tag} -container-tag-alt=${docker_tag_alt} -container-prefix=${functest_docker_prefix} -image-prefix-alt=${image_prefix_alt} -oc-path=${oc} -kubectl-path=${kubectl} -gocli-path=${gocli} -installed-namespace=${namespace} -previous-release-tag=${PREVIOUS_RELEASE_TAG} -previous-release-registry=${previous_release_registry} -deploy-testing-infra=${deploy_testing_infra} -config=${kubevirt_test_config} --artifacts=${ARTIFACTS} --operator-manifest-path=${OPERATOR_MANIFEST_PATH} --testing-manifest-path=${TESTING_MANIFEST_PATH} ${KUBEVIRT_FUNC_TEST_SUITE_ARGS} -virtctl-path=${virtctl_path} -example-guest-agent-path=${example_guest_agent_path} | |||
There was a problem hiding this comment.
Can you clarify why the slow spec threshold is now 60 instead of 30?
There was a problem hiding this comment.
The flag -slow-spec-threshold has been deprecated among others with v2.5, therefore I have removed it.
There was a problem hiding this comment.
My bad! I got confused with colors 🤦
xpivarc
reviewed
Jul 4, 2023
kubevirt-bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xpivarc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/lgtm |
|
/hold cancel |
kubevirt-bot
removed
the
do-not-merge/hold
|
/skip |
|
/retest-required |
|
@dhiller: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
According to A Survey of Flaky Tests, Section Detection
platform, so environmental issues should be considered with
higher priority
tests
may be more efficient and effective than more sophisticated
approaches
consecutively fail up to a maximum of five times before
passing,
though another reported finding new flaky tests even after
10,000 test suite runs.”
Therefore we by default
We fix a couple of deprecated ginkgo flags along the way.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: