Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHCPv6 server should handle request without iana option #9845

Merged
merged 1 commit into from
Jun 6, 2023
Merged

DHCPv6 server should handle request without iana option #9845

merged 1 commit into from
Jun 6, 2023

Conversation

lxs137
Copy link
Contributor

@lxs137 lxs137 commented Jun 2, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9843

Special notes for your reviewer:

Release note:

DHCPv6 server handle request without iana option

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 2, 2023
@kubevirt-bot
Copy link
Contributor

Hi @lxs137. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhiller
Copy link
Contributor

dhiller commented Jun 2, 2023

/cc @phoracek @EdDev @ormergi

@dhiller
Copy link
Contributor

dhiller commented Jun 2, 2023

/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 2, 2023
@EdDev
Copy link
Member

EdDev commented Jun 2, 2023

DHCPv6 server should handle request without iana option

Could you please reason for it?

@EdDev
Copy link
Member

EdDev commented Jun 2, 2023

/ok-to-test

@dhiller this may be unsafe.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2023
@lxs137
Copy link
Contributor Author

lxs137 commented Jun 5, 2023 •
edited

DHCPv6 server should handle request without iana option

Could you please reason for it?

@EdDev
I found my VM could send dhcpv6 Information-request, which not contains IA_NA Option, the request will cause virt-launcher crash.

More details please look at #9843

@lxs137 lxs137 force-pushed the fix/handle-dhcpv6-request-without-iana branch from 0366a53 to 50322ad Compare June 5, 2023 03:44
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2023
@EdDev
Copy link
Member

EdDev commented Jun 5, 2023

@EdDev I found my VM could send dhcpv6 Information-request, which not contains IA_NA Option, the request will cause virt-launcher crash.

More details please look at #9843

Thank you.
Could you please update the commit message with this info so we will have it logged for future us?
E.g. something like:

When sending DHCPv6 InformationRequest (not contains IA_NA option), the request will cause
virt-launcher DHCPv6 server crash.

@lxs137
virt-launcher: DHCPv6 server should handle request without IA_NA Option
6159e9e 
GuestOS could send dhcpv6 Information-request, which not contains IA_NA Option,
so we should check IA_NA Option existence when handle request.

Signed-off-by: menyakun <lxs137@hotmail.com>
EdDev
EdDev reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@EdDev EdDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good, thank you.
Please just justify/reason the change in the commit message so we would have this information available in the future.

it would also be helpful if you can confirm that this has been tested with the mentioned Ubuntu OS, assuring it solved the problem.
We do not have e2e tests to cover it.

@lxs137 lxs137 force-pushed the fix/handle-dhcpv6-request-without-iana branch from 50322ad to 6159e9e Compare June 5, 2023 05:53
@lxs137
Copy link
Contributor Author

lxs137 commented Jun 5, 2023

assuring

@EdDev I have updated the commit message. The bugfix works well on my Ubuntu GuestOS :-)

EdDev
EdDev approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@EdDev EdDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
@EdDev
Copy link
Member

EdDev commented Jun 5, 2023

/assign @AlonaKaplan

@lxs137
Copy link
Contributor Author

lxs137 commented Jun 5, 2023

/test pull-kubevirt-e2e-k8s-1.27-sig-compute

@lxs137
Copy link
Contributor Author

lxs137 commented Jun 5, 2023

/test pull-kubevirt-unit-test

@lxs137
Copy link
Contributor Author

lxs137 commented Jun 5, 2023

/retest

maiqueb
maiqueb approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good.

@AlonaKaplan
Copy link
Member

Thanks!
/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@lxs137
Copy link
Contributor Author

lxs137 commented Jun 6, 2023

/retest

@kubevirt-bot kubevirt-bot merged commit 2060ce8 into kubevirt:main Jun 6, 2023
34 checks passed
@kubevirt-bot kubevirt-bot mentioned this pull request Jul 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdDev EdDev EdDev approved these changes

@maiqueb maiqueb maiqueb approved these changes

@dhiller dhiller Awaiting requested review from dhiller

@vasiliy-ul vasiliy-ul Awaiting requested review from vasiliy-ul

@ormergi ormergi Awaiting requested review from ormergi

@phoracek phoracek Awaiting requested review from phoracek

Assignees

@EdDev EdDev

@AlonaKaplan AlonaKaplan

@maiqueb maiqueb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GuestOS send DHCPv6 request will cause virt-launcher crash
7 participants
@lxs137 @kubevirt-bot @dhiller @EdDev @AlonaKaplan @kubevirt-commenter-bot @maiqueb